Update dependencies coming from maintenance-packages #18329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ No release notes required |
|
@ViktorHofer @ericstj this is ready to review. Same changes as in the test PR in dotnet/dotnet: https://github.com/dotnet/dotnet/pull/155/files |
|
The CI is failing because fsharp depends on source-build-reference-packages from release/9.0. Is that correct? See the branch of origin in all the recent PRs: |
|
@dotnet/fsharp-team-msft This is blocked by #18398 |
…ence-packages build 20250320.3 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 9.0.0-alpha.1.25163.3 -> To Version 9.0.0-alpha.1.25170.3
|
code formatting change is unrelated: PR to fix in process: #18404 |
|
CI looks good. I think the conditions that I removed are no longer needed, particularly because we have merged the ref packages to the source-build-reference-packages repo. @KevinRansom or @T-Gro can you please merge? |
KevinRansom
approved these changes
Mar 25, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
T-Gro
approved these changes
Mar 25, 2025
|
Mentioned offline to Kevin - This is now blocking the msbuild deps flow into sdk: dotnet/sdk#47853 |
carlossanlop
commented
Mar 25, 2025
carlossanlop
commented
Mar 25, 2025
github-project-automation
bot
moved this from In Progress
to Done
in F# Compiler and Tooling
T-Gro
added a commit
that referenced
this pull request
Mar 26, 2025
* Use correct TFM for source build when OfficialBuildId isn't set (#18397) * Update dependencies coming from maintenance-packages (#18329) * Update dependencies coming from maintenance-packages * Remove temp feed * Sort * Push for real the changes this time * Update to latest in nuget.org * Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20250320.3 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 9.0.0-alpha.1.25163.3 -> To Version 9.0.0-alpha.1.25170.3 * Bring back conditions * missing space --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com> Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> --------- Co-authored-by: Matt Thalman <mthalman@microsoft.com> Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com> Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is result of testing the parallel dependency updates to ensure source-build does not break: dotnet/dotnet#133
IMPORTANT: I need to merge this PR at the same time as all the other PRs in the other repos, to prevent breaking the dependency ingestion in the dotnet/sdk repo.
cc @ericstj @ViktorHofer