Fixing #461 - warning with a reference to non existing location in source file #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ready for review |
dsyme
changed the title
dsyme
reviewed
Nov 27, 2016
| @@ -2,7 +2,7 @@ | |||
| // Empty program entry point warning | |||
| // Lack of entry point produces warning with correct source location when compiled to *.exe | |||
| // when source file declares type inside namespace | |||
| //<Expects id="FS0988" span="(1,81-1,81)" status="warning">Main module of program is empty: nothing will happen when it is run</Expects> | |||
| //<Expects id="FS0988" span="(10,18-10,18)" status="warning">Main module of program is empty: nothing will happen when it is run</Expects> | |||
There was a problem hiding this comment.
Agreed we shouldn't report a non-existent location, but we need to report this on some actual source text, not a single character
There was a problem hiding this comment.
it always only used the m.EndRange for the error
There was a problem hiding this comment.
There was a problem hiding this comment.
I see. I guess a real single character is better than a non-existent single character :)
It would be better to give the error at a more real textual range but that is indeed further work
|
ready for review |
|
@dotnet-bot test this please |
KevinRansom
approved these changes
Dec 13, 2016
|
Thanks for taking care of this Kevin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.