Enable Net Sdk to write project properties #4430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
force-pushed
the
sdkproperties
branch
from
94424d3 to
37973e5
Compare
KevinRansom
force-pushed
the
sdkproperties
branch
from
25a8969 to
d3c745f
Compare
brettfo
reviewed
Mar 9, 2018
| </PropertyGroup> | ||
|
|
||
| <Target Name="CoreGenerateAssemblyInfo" | ||
| Condition="'$(Language)'=='F#'" |
There was a problem hiding this comment.
Update the condition to '$(Language)' == 'F#' AND '$(GenerateAssemblyInfo)' != 'false'.
There was a problem hiding this comment.
I believe this is handled by the DotNET Sdk here: https://github.com/dotnet/sdk/blob/6945e3694c918eea4c8c4fb6217e1485b179994b/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.GenerateAssemblyInfo.targets
brettfo
approved these changes
Mar 14, 2018
|
Note that dotnet/sdk#2021 was closed in favor of dotnet/sdk#2023, which appears (based on the description) to be the same fix. I mention this in case anyone follows the link from #3113 (which requires this bugfix in order to work) and feels concerned that the linked PR was closed. |
|
Thanks mate :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3113
This requires a Net Sdk fix: dotnet/sdk#2021
Adds a new target file to handle the overrides. This was necessary, because the FSharp.NetSdk target files occurs before the NetSdk targets are defined.
Once the infra is done, the fix is trivial, just override CoreGenerateAssemblyInfo and run it for F# files only. Include the output in CompileBefore.
The remainder is just deployment nonsense.
Kevin
/cc @nguerrera, @enricosada, @TIHan @dsyme