Add netsdk overrides #2023
Merged
Add netsdk overrides #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguerrera
approved these changes
Mar 7, 2018
|
Note this will need ask mode approval. |
|
@nguerrera yep I get that. |
|
@dotnet-bot test OSX10.12 Debug please |
JL03-Yue
pushed a commit
that referenced
this pull request
Mar 19, 2024
…110.1 (#2023) [main] Update dependencies from dotnet/arcade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way F# is integrated into the Net Sdk it is not possible for an F# target file to override SDK targets.
We need to be able to do that to enable the Net Sdkmechanism to add AssemblyInfo properties to F# apps and libraries.
This PR renames the existing Microsoft.Net.Sdk.FSharp.targets to Microsoft.FSharp.NetSdk.targets, so that we can use the name Microsoft.Net.Sdk.FSharp.targets consistently with C# and VB.
Microsoft.Net.Sdk.FSharp.targets selects a target file deployed with F# compiler.
@nguerrera, @livarcocc , @brettfo