No need to decompile coreDisplayName all the time #4443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
reviewed
Mar 6, 2018
src/fsharp/TypeChecker.fs
Outdated
| if (idRange.EndColumn - idRange.StartColumn <= 5) && | ||
| not cenv.g.compilingFslib | ||
| then | ||
| let opName = DecompileOpName coreDisplayName |
There was a problem hiding this comment.
Not every branch of the pattern uses DecompileOpName.
With this change, it will happen regardless of the branch executed. Im guessing that it will now be called more times.
I suppose you can make it lazy with: let opName () = DecompileOpName coreDisplayName
Kevin
There was a problem hiding this comment.
Okay upon closer look, this looks good. Ignore my prvious comment.
TIHan
reviewed
Mar 7, 2018
src/fsharp/TypeChecker.fs
Outdated
| match opName with | ||
| | PrettyNaming.Relational -> | ||
| if isMember then | ||
| warning(StandardOperatorRedefinitionWarning(FSComp.SR.tcInvalidMethodNameForRelationalOperator(opName, (CompileOpName opName)), idRange)) | ||
| if Option.isSome memberInfoOpt then |
There was a problem hiding this comment.
Can we bring this up? ex: let isMember = Option.isSome memberInfoOpt and use isMember
There was a problem hiding this comment.
I would prefer memberInfoOpt.IsSome to Option.isSome memberInfoOpt. Use properties if they are there
forki
force-pushed
the
CheckForAbnormalOperatorNames
branch
2 times, most recently
from
3b0ac24 to
07d31bc
Compare
|
done. |
forki
force-pushed
the
CheckForAbnormalOperatorNames
branch
from
07d31bc to
29e9ad6
Compare
TIHan
approved these changes
Mar 8, 2018
|
Thanks for this. |
KevinRansom
pushed a commit
that referenced
this pull request
Mar 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.