Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcut NameResolution searches #4444

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Shortcut NameResolution searches #4444

merged 1 commit into from
Mar 9, 2018

Conversation

forki
Copy link
Contributor

@forki forki commented Mar 6, 2018

No description provided.

@forki forki force-pushed the shortcutnames branch 2 times, most recently from c1868a0 to bfce1c0 Compare March 6, 2018 13:28
@forki forki closed this Mar 6, 2018
@forki forki reopened this Mar 6, 2018
dsyme
dsyme requested changes Mar 7, 2018
View reviewed changes
Copy link
Contributor

@dsyme dsyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I can see why you want to make the short-cut explicit.

One minor change - please do not use cascading indent and just align the default fall-through of the match.

src/fsharp/NameResolution.fs Outdated
match tyconResult with
| Result (res :: _) -> res
| _ ->
let moduleResult = moduleSearch ad
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to indent the fallthrough branch of the match

@forki
Copy link
Contributor Author

forki commented Mar 8, 2018

done.

@KevinRansom KevinRansom merged commit 792dbe5 into dotnet:master Mar 9, 2018
KevinRansom pushed a commit that referenced this pull request Mar 9, 2018
@dotnet-bot @KevinRansom
Merge master to dev15.7 (#4475)
3bdd481 
* One lookup in nenv.eFieldLabels should be enough (#4469)

* Shortcut NameResolution searches (#4444)

* No need to decompile coreDisplayName all the time (#4443)
@forki forki deleted the shortcutnames branch March 13, 2018 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsyme dsyme dsyme requested changes

@KevinRansom KevinRansom KevinRansom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@forki @KevinRansom @dsyme