Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master to dev16.1 #6252

Merged
merged 7 commits into from
Feb 19, 2019
Merged

Merge master to dev16.1 #6252

merged 7 commits into from
Feb 19, 2019

Conversation

dotnet-bot
Copy link
Contributor

This is an automatically generated pull request from master into dev16.1.

git fetch --all
git checkout merges/master-to-dev16.1
git reset --hard upstream/dev16.1
git merge upstream/master
# Fix merge conflicts
git commit
git push upstream merges/master-to-dev16.1 --force

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.

brettfo and others added 6 commits February 6, 2019 20:21
…uild (#6206)

* Ensure core tests pick up fsharp.core nuget packages from artifacts build

* Feedback
* Update mono props: support OSX and more .NET Framework versions

A potential solve for #6180 that uses msbuild built-ins to determine the target OS and pivots off of that to set the FrameworkPathOverride.  I included a `MonoRoot` property to allow for easy integration into the build process that fsharp/fsharp uses, which allows for a 'floating' mono root.

* add osx build jobs matching the linux jobs, and add a matrix entry to build the compiler for .net framework using mono

* don't try to build anything for .net framework on non-windows

this required additional build work that may conflict with upcoming work, so we'll just settle for building the existing components on macos at all in CI
* fix double-build of vsix packages (#6232)

* Update Microsoft.FSharp.vsmanproj
* debug fixes

* apply code review fixes
@brettfo brettfo force-pushed the merges/master-to-dev16.1 branch from 70b5d2a to fc15661 Compare February 19, 2019 22:39
@brettfo brettfo merged commit bce0c11 into dev16.1 Feb 19, 2019
@brettfo brettfo deleted the merges/master-to-dev16.1 branch February 19, 2019 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants