Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSharp.Compiler.Private -> .NET Standard 2.0 #7959

Closed
wants to merge 2 commits into from

Conversation

cartermp
Copy link
Contributor

No description provided.

@cartermp
Copy link
Contributor Author

Only a few thousand test failures, how hard could it be?

@NatElkins
Copy link
Contributor

Seems like a ton of the errors are coming from here: https://github.com/dotnet/fsharp/blob/master/src/utils/reshapedmsbuild.fs#L822

@cartermp
Copy link
Contributor Author

@NatElkins Yeah, it's the center of all of our woes, actually. This wonderful system, built a long time ago, only executes on .NET Desktop with the desktop compiler. However...

  • We must still build and test the desktop compiler
  • Every FSharpQA test uses the desktop compiler to execute

So it is a significant investment involved to finally be rid of the .NET Framework target in this project.

@cartermp
Copy link
Contributor Author

Gonna close this one out. We can do this, but I think it's going to depend on fsharpqa getting moved first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants