Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yeet fx_reshaped_msbuild #9780

Merged
merged 2 commits into from
Jul 25, 2020
Merged

Conversation

KevinRansom
Copy link
Member

@KevinRansom KevinRansom commented Jul 25, 2020

I have always been embarrassed by reshaped_msbuild. However, now it is completely unnecessary, and so, it is with great joy that I consign it to the bit bucket in the sky.

Oh yeah and update the msbuild libraries to the latest bits.

@cartermp
Copy link
Contributor

oh boy oh boy oh boy oh boy

looks like the fcs project needs updating as well

@cartermp
Copy link
Contributor

oh man the magic reflection going on in here was a primary source of blocking this: #7959

@cartermp
Copy link
Contributor

cartermp commented Jul 25, 2020

Just curious, what's the history of this thing?

@KevinRansom
Copy link
Member Author

It came into existence when I did the original coreclr port. If you remember netstandard was at about 1.3 at that point, and I think it had not even been released then. Anyway, the compiler had a huge dependency on msbuild, and the port to coreclr hadn't started then. Because ... project.json.

Anyway, tons of the compiler and FSI did resolution using msbuild API's we needed some of that code in our compiler just to even compile it.

Over the years we have abstracted things, simplified things in the compiler, and msbuild got ported to the coreclr. So ... I thought I would try to yeet it, and it worked.

In a future PR, will I will turn on the msbuildresolution resolver on the coreclr version of the compiler. It should help with replacing the desktop compiler.

@cartermp
Copy link
Contributor

Oh, our old friends project.json. I fondly recall my first PR here was involving that: #1225

Great to see this getting cleaned up!

@KevinRansom KevinRansom merged commit 2a8943c into dotnet:master Jul 25, 2020
@KevinRansom KevinRansom deleted the netstandardmsbuild branch August 19, 2020 20:21
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
* Yeet fx_reshaped_msbuild

* Update fcs build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants