Allow builds to specialise the package ID of generated Runtime, Visualisers, and Compiler NuGet packages #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m3nikma7i
reviewed
Apr 23, 2020
src/Compiler/Compiler.csproj
Outdated
| @@ -5,6 +5,7 @@ | |||
| <Description>Infer.NET is a framework for running Bayesian inference in graphical models. It can also be used for probabilistic programming. This package contains the Infer.NET Compiler, which takes model descriptions written using the Infer.NET API and converts them into inference code.</Description> | |||
| <TargetFramework>netstandard2.0</TargetFramework> | |||
| <AssemblyName>$(AssemblyNamePrefix)Microsoft.ML.Probabilistic.Compiler</AssemblyName> | |||
| <PackageId>$(AssemblyName)(NuGetPackageIdSuffix)</PackageId> | |||
There was a problem hiding this comment.
Lacks $.
Did this actually produce the correct packages? (Builds are gone...)
What will $(NugetPackageIdSuffix) be set to? Could you please provide examples of how the package names would look like?
…dotnet/infer into jotims/pr/enable-package-suffix
m3nikma7i
approved these changes
Apr 23, 2020
tminka
pushed a commit
to kant2002/infer
that referenced
this pull request
Aug 24, 2020
…lisers, and Compiler NuGet packages (dotnet#236) This allows you to avoid confusion of private internal versions of these packages, with those on nuget.org or other feeds with other privately build versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to avoid confusion of private internal versions of these packages, with those on nuget.org or other feeds with other privately build versions.