Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow builds to specialise the package ID of generated Runtime, Visualisers, and Compiler NuGet packages #236

Merged
merged 5 commits into from
Apr 23, 2020
Merged

Allow builds to specialise the package ID of generated Runtime, Visualisers, and Compiler NuGet packages #236

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e96b9c4
wip
jonathantims Apr 8, 2020
3c7d87b
Merge branch 'master' into jotims/pr/enable-package-suffix
jonathantims Apr 12, 2020
db02ae3
wip
jonathantims Apr 23, 2020
887cd16
Merge branch 'jotims/pr/enable-package-suffix' of https://github.com/…
jonathantims Apr 23, 2020
48419c6
Merge branch 'master' into jotims/pr/enable-package-suffix
jonathantims Apr 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Compiler/Compiler.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<Description>Infer.NET is a framework for running Bayesian inference in graphical models. It can also be used for probabilistic programming. This package contains the Infer.NET Compiler, which takes model descriptions written using the Infer.NET API and converts them into inference code.</Description>
<TargetFramework>netstandard2.0</TargetFramework>
<AssemblyName>$(AssemblyNamePrefix)Microsoft.ML.Probabilistic.Compiler</AssemblyName>
<PackageId>$(AssemblyName)(NuGetPackageIdSuffix)</PackageId>
Copy link

@m3nikma7i m3nikma7i Apr 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lacks $.

Did this actually produce the correct packages? (Builds are gone...)

What will $(NugetPackageIdSuffix) be set to? Could you please provide examples of how the package names would look like?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in person.

<DefineConstants>TRACE;SUPPRESS_XMLDOC_WARNINGS, SUPPRESS_UNREACHABLE_CODE_WARNINGS, SUPPRESS_AMBIGUOUS_REFERENCE_WARNINGS</DefineConstants>
<NoWarn>1591</NoWarn>
<RootNamespace>Microsoft.ML.Probabilistic</RootNamespace>
Expand Down
1 change: 1 addition & 0 deletions src/Runtime/Runtime.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<Description>Infer.NET is a framework for running Bayesian inference in graphical models. It can also be used for probabilistic programming. This package contains classes and methods needed to execute the inference code.</Description>
<TargetFramework>netstandard2.0</TargetFramework>
<AssemblyName>$(AssemblyNamePrefix)Microsoft.ML.Probabilistic</AssemblyName>
<PackageId>$(AssemblyName)$(NuGetPackageIdSuffix)</PackageId>
<DefineConstants>TRACE;SUPPRESS_XMLDOC_WARNINGS, SUPPRESS_UNREACHABLE_CODE_WARNINGS</DefineConstants>
<NoWarn>1591</NoWarn>
<RootNamespace>Microsoft.ML.Probabilistic</RootNamespace>
Expand Down
2 changes: 1 addition & 1 deletion src/Visualizers/Windows/Visualizers.Windows.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<Description>Infer.NET is a framework for running Bayesian inference in graphical models. It can also be used for probabilistic programming. This package contains visualization tools for exploring and analyzing models on Windows platform.</Description>
<TargetFramework>net461</TargetFramework>
<AssemblyName>Microsoft.ML.Probabilistic.Compiler.Visualizers.Windows</AssemblyName>
<PackageId>Microsoft.ML.Probabilistic.Visualizers.Windows</PackageId>
<PackageId>Microsoft.ML.Probabilistic.Visualizers.Windows$(NuGetPackageIdSuffix)</PackageId>
<DefineConstants>TRACE;SUPPRESS_XMLDOC_WARNINGS, SUPPRESS_UNREACHABLE_CODE_WARNINGS, SUPPRESS_AMBIGUOUS_REFERENCE_WARNINGS</DefineConstants>
<NoWarn>1591</NoWarn>
<RootNamespace>Microsoft.ML.Probabilistic.Compiler.Visualizers</RootNamespace>
Expand Down