Fix exceptions' swallowing #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donJoseLuis
approved these changes
Nov 12, 2020
nohwnd
requested changes
Nov 12, 2020
bekir-ozturk
approved these changes
Nov 16, 2020
nohwnd
approved these changes
Nov 20, 2020
| @@ -721,8 +743,7 @@ New-Item -ItemType Directory -Force -Path $InstallRoot | Out-Null | |||
| $installDrive = $((Get-Item $InstallRoot).PSDrive.Name); | |||
| $diskInfo = Get-PSDrive -Name $installDrive | |||
| if ($diskInfo.Free / 1MB -le 100) { | |||
There was a problem hiding this comment.
nit:
Suggested change
| if ($diskInfo.Free / 1MB -le 100) { | |
| if ($diskInfo.Free -le 100MB) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially delivers issue #27 and issue #9.
This is the first part of planned fixes of error diagnosis in the scripts. The changes partially fix exceptions' swallowing.
Also, this closes the debts from PR #96 and PR #97.