Skip to content

install scripts should remove temp zip file #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 11, 2020
Merged

install scripts should remove temp zip file #97

merged 4 commits into from
Nov 11, 2020

Conversation

@vlada-shubina
Copy link
Member

fixes #45:

  • install-scripts.sh - temp zip file is now removed before script exits
  • install-scripts.ps1 - added removing of zip file in case of download failure and log messages

@vlada-shubina vlada-shubina requested a review from a team November 6, 2020 13:32
@vlada-shubina vlada-shubina self-assigned this Nov 6, 2020
bekir-ozturk
bekir-ozturk reviewed Nov 6, 2020
View reviewed changes
@vlada-shubina
Copy link
Member Author

vlada-shubina commented Nov 6, 2020 •
edited
Loading

Note for:

Could consider also a more distinct temp file name and cleaning up someDistinctDotNettyName.* in TMP every time.

  • I can change the pattern for temp file generation to better one: currently we use <random> for PS1 and dotnet.<random> for SH, however please advise on pattern.
  • I would not recommend cleaning up any files which were not created by the current script run, this behavior opens a breach and might cause accidental removal of files which are not supposed to be removed. After this PR the error on file removal would be shown in output, so the manual action can be taken if temp files were not removed.

AR-May
AR-May reviewed Nov 10, 2020
View reviewed changes
@vlada-shubina
fixes dotnet#45:
e71ee8b 
- install-scripts.sh - temp zip file is now removed before script exits
- install-scripts.ps1 - added removing of zip file in case of download failure and log messages

(cherry picked from commit 572dd2a9f24b64f25ea6b9dae9f18b7e4fa4a653)
@vlada-shubina
fixed whitespaces changes
5f2f613
@vlada-shubina
more whitespace changes
2b63893
@vlada-shubina
change to message wording
cb79296
@vlada-shubina vlada-shubina merged commit 8765035 into dotnet:master Nov 11, 2020
@vlada-shubina vlada-shubina deleted the remove-temp-files branch November 11, 2020 12:11
@AR-May AR-May mentioned this pull request Nov 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AR-May AR-May AR-May approved these changes

+3 more reviewers

@nohwnd nohwnd nohwnd left review comments

@bekir-ozturk bekir-ozturk bekir-ozturk left review comments

@donJoseLuis donJoseLuis donJoseLuis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vlada-shubina vlada-shubina

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Repeated invocations of dotnet-install.sh will fill TMP directory

5 participants

@vlada-shubina @nohwnd @donJoseLuis @bekir-ozturk @AR-May