[main] Update dependencies from dotnet/sdk #16005

dotnet-maestro · 2023-04-06T17:54:14Z

This pull request updates the following dependencies

From https://github.com/dotnet/sdk

Subscription: f8ee08b0-6c3d-485a-6895-08db0a1df366
Build: 20230407.19
Date Produced: April 8, 2023 12:21:16 AM UTC
Commit: 15dd3db
Branch: refs/heads/main

Updates:
- Microsoft.DotNet.Common.ItemTemplates: from 8.0.100-preview.4.23206.6 to 8.0.100-preview.4.23207.19
- Microsoft.DotNet.MSBuildSdkResolver: from 8.0.100-preview.4.23206.6 to 8.0.100-preview.4.23207.19
- Microsoft.NET.Sdk: from 8.0.100-preview.4.23206.6 to 8.0.100-preview.4.23207.19
- Microsoft.TemplateEngine.Cli: from 8.0.100-preview.4.23206.6 to 8.0.100-preview.4.23207.19
- VS.Redist.Common.NetCore.SharedFramework.x64.8.0: from 8.0.0-preview.4.23181.2 to 8.0.0-preview.4.23207.2
- Microsoft.NETCore.App.Ref: from 8.0.0-preview.4.23181.2 to 8.0.0-preview.4.23207.2
- VS.Redist.Common.NetCore.TargetingPack.x64.8.0: from 8.0.0-preview.4.23181.2 to 8.0.0-preview.4.23207.2
- Microsoft.NETCore.App.Host.win-x64: from 8.0.0-preview.4.23181.2 to 8.0.0-preview.4.23207.2
- Microsoft.NETCore.DotNetHostResolver: from 8.0.0-preview.4.23181.2 to 8.0.0-preview.4.23207.2
- Microsoft.NETCore.Platforms: from 8.0.0-preview.4.23181.2 to 8.0.0-preview.4.23207.2
- Microsoft.AspNetCore.App.Ref: from 8.0.0-preview.4.23205.4 to 8.0.0-preview.4.23207.3
- Microsoft.AspNetCore.App.Ref.Internal: from 8.0.0-preview.4.23205.4 to 8.0.0-preview.4.23207.3
- Microsoft.AspNetCore.App.Runtime.win-x64: from 8.0.0-preview.4.23205.4 to 8.0.0-preview.4.23207.3
- VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0: from 8.0.0-preview.4.23205.4 to 8.0.0-preview.4.23207.3
- dotnet-dev-certs: from 8.0.0-preview.4.23205.4 to 8.0.0-preview.4.23207.3
- dotnet-user-jwts: from 8.0.0-preview.4.23205.4 to 8.0.0-preview.4.23207.3
- dotnet-user-secrets: from 8.0.0-preview.4.23205.4 to 8.0.0-preview.4.23207.3
- Microsoft.FSharp.Compiler: from 12.5.0-beta.23180.1 to 12.5.0-beta.23203.7
- Microsoft.SourceBuild.Intermediate.fsharp: from 7.0.300-beta.23180.1 to 7.0.300-beta.23203.7
- Microsoft.NET.ILLink.Tasks: from 8.0.0-preview.4.23181.2 to 8.0.0-preview.4.23207.2
- Microsoft.Build: from 17.7.0-preview-23204-03 to 17.7.0-preview-23206-02
- Microsoft.NETCore.App.Runtime.win-x64: from 8.0.0-preview.4.23181.2 to 8.0.0-preview.4.23207.2

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

Coherency Updates:
- VS.Redist.Common.NetCore.SharedFramework.x64.8.0: from 8.0.0-preview.4.23181.2 to 8.0.0-preview.4.23207.2 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.App.Ref: from 8.0.0-preview.4.23181.2 to 8.0.0-preview.4.23207.2 (parent: Microsoft.NET.Sdk)
- VS.Redist.Common.NetCore.TargetingPack.x64.8.0: from 8.0.0-preview.4.23181.2 to 8.0.0-preview.4.23207.2 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.App.Host.win-x64: from 8.0.0-preview.4.23181.2 to 8.0.0-preview.4.23207.2 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.DotNetHostResolver: from 8.0.0-preview.4.23181.2 to 8.0.0-preview.4.23207.2 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.Platforms: from 8.0.0-preview.4.23181.2 to 8.0.0-preview.4.23207.2 (parent: Microsoft.NET.Sdk)
- Microsoft.AspNetCore.App.Ref: from 8.0.0-preview.4.23205.4 to 8.0.0-preview.4.23207.3 (parent: Microsoft.NET.Sdk)
- Microsoft.AspNetCore.App.Ref.Internal: from 8.0.0-preview.4.23205.4 to 8.0.0-preview.4.23207.3 (parent: Microsoft.NET.Sdk)
- Microsoft.AspNetCore.App.Runtime.win-x64: from 8.0.0-preview.4.23205.4 to 8.0.0-preview.4.23207.3 (parent: Microsoft.NET.Sdk)
- VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0: from 8.0.0-preview.4.23205.4 to 8.0.0-preview.4.23207.3 (parent: Microsoft.NET.Sdk)
- dotnet-dev-certs: from 8.0.0-preview.4.23205.4 to 8.0.0-preview.4.23207.3 (parent: Microsoft.NET.Sdk)
- dotnet-user-jwts: from 8.0.0-preview.4.23205.4 to 8.0.0-preview.4.23207.3 (parent: Microsoft.NET.Sdk)
- dotnet-user-secrets: from 8.0.0-preview.4.23205.4 to 8.0.0-preview.4.23207.3 (parent: Microsoft.NET.Sdk)
- Microsoft.FSharp.Compiler: from 12.5.0-beta.23180.1 to 12.5.0-beta.23203.7 (parent: Microsoft.NET.Sdk)
- Microsoft.SourceBuild.Intermediate.fsharp: from 7.0.300-beta.23180.1 to 7.0.300-beta.23203.7 (parent: Microsoft.NET.Sdk)
- Microsoft.NET.ILLink.Tasks: from 8.0.0-preview.4.23181.2 to 8.0.0-preview.4.23207.2 (parent: Microsoft.NET.Sdk)
- Microsoft.Build: from 17.7.0-preview-23204-03 to 17.7.0-preview-23206-02 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.App.Runtime.win-x64: from 8.0.0-preview.4.23181.2 to 8.0.0-preview.4.23207.2 (parent: Microsoft.NET.Sdk)

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.4.23206.6 -> To Version 8.0.100-preview.4.23206.9

dotnet-maestro · 2023-04-06T17:55:36Z

Notification for subscribed users from https://github.com/dotnet/sdk:

@dotnet/domestic-cat

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/sdk) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.4.23206.6 -> To Version 8.0.100-preview.4.23206.10 Dependency coherency updates Microsoft.NET.Test.Sdk From Version 17.6.0-preview-20230323-05 -> To Version 17.7.0-preview.23205.10 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.4.23206.6 -> To Version 8.0.100-preview.4.23206.11 Dependency coherency updates VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Build,Microsoft.NETCore.App.Runtime.win-x64 From Version 8.0.0-preview.4.23181.2 -> To Version 8.0.0-preview.4.23206.2 (parent: Microsoft.NET.Sdk

lewing · 2023-04-06T19:17:24Z

@MichaelSimons @mmitche looks like something is wrong with VMR sync?

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.4.23206.6 -> To Version 8.0.100-preview.4.23206.12 Dependency coherency updates VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Build,Microsoft.NETCore.App.Runtime.win-x64 From Version 8.0.0-preview.4.23181.2 -> To Version 8.0.0-preview.4.23206.3 (parent: Microsoft.NET.Sdk

lewing · 2023-04-06T20:11:37Z

@mmithce and now the pipeline seems to be down ~~https://dev.azure.com/dnceng-public/public/_build?definitionId=233&_a=summary&view=triggerIssues~~ just took an our for the build to show up in the azdo Queue

lewing · 2023-04-06T20:56:12Z

info: Applying patch /mnt/vss/_work/1/vmr/src/installer/src/SourceBuild/patches/runtime/0001-Fix-for-item-based-msbuild-pattern.patch to src/runtime...
dbug: Executing command: 'git -C /mnt/vss/_work/1/vmr config apply.ignoreWhitespace change'
dbug: Executing command: 'git -C /mnt/vss/_work/1/vmr apply --cached --ignore-space-change --directory src/runtime /mnt/vss/_work/1/vmr/src/installer/src/SourceBuild/patches/runtime/0001-Fix-for-item-based-msbuild-pattern.patch'
warn: A new branch was created for the sync and didn't get merged as the sync was interrupted. A new sync should start from 16005/merge branch.
fail: Failed to synchronize repo installer
      Failed to apply the patch for src/runtime
      Exit code: 1
      Std err:
      error: patch failed: src/runtime/src/tasks/Crossgen2Tasks/Microsoft.NET.CrossGen.targets:346
      error: src/runtime/src/tasks/Crossgen2Tasks/Microsoft.NET.CrossGen.targets: patch does not apply

MichaelSimons · 2023-04-06T20:59:27Z

I will address the patch conflict.

lewing · 2023-04-06T20:59:45Z

@baronfel it looks like dotnet/runtime#82804 broke source build

MichaelSimons · 2023-04-06T21:01:59Z

I addressed the source-build patch conflict. One of the patches that had been backported flowed in so the patch needed to be removed.

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.4.23206.6 -> To Version 8.0.100-preview.4.23206.19 Dependency coherency updates VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Build,Microsoft.NETCore.App.Runtime.win-x64 From Version 8.0.0-preview.4.23181.2 -> To Version 8.0.0-preview.4.23206.3 (parent: Microsoft.NET.Sdk

lewing · 2023-04-06T22:51:00Z

source-build failed again

/vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Version.BeforeCommonTargets.targets(54,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression ""23205.10".Substring(9)" cannot be evaluated. startIndex cannot be larger than length of string. (Parameter 'startIndex')

https://github.com/dotnet/arcade/blob/d7b5c2c026141e80abf3acca2f957c52949929cc/src/Microsoft.DotNet.Arcade.Sdk/tools/Version.BeforeCommonTargets.targets#L54

MichaelSimons · 2023-04-06T23:07:04Z

source-build failed again
/vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Version.BeforeCommonTargets.targets(54,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression ""23205.10".Substring(9)" cannot be evaluated. startIndex cannot be larger than length of string. (Parameter 'startIndex')
https://github.com/dotnet/arcade/blob/d7b5c2c026141e80abf3acca2f957c52949929cc/src/Microsoft.DotNet.Arcade.Sdk/tools/Version.BeforeCommonTargets.targets#L54

I believe this is a result of vstest onboarding to arcade and their version number scheme changing (https://github.com/dotnet/installer/pull/16005/files#diff-fb62e94a1d6f29f863e3d0a22aa38269f6cd1d7f03b109dc06e2cbf2548b86d3L140). There was special logic to handle there old version number scheme here. I believe the special case needs to simply be removed. I am not certain how to flow this change though and the Prague eng svcs folks are out till Tuesday. @mmitche do you know?

mmitche · 2023-04-06T23:26:15Z

That's odd that that code path would be hitting here. But also, that special casing might need to be removed. I'm surprised that it didn't fail to publish in their repo...very weird. I'll dig into this.

lewing · 2023-04-06T23:36:20Z

I opened dotnet/sdk#31658 to unblock all installer prs in the meantime

mmitche · 2023-04-06T23:38:00Z

I see, this was a VMR-specific around for vstest. @MichaelSimons's change should be checked in, then we do update-dependencies in this PR against the new arcade-services build.

mmitche · 2023-04-06T23:38:43Z

@lewing We should be able to have a new build in a relatively short period of time (< the revert and flow)

mmitche · 2023-04-06T23:42:07Z

If it's time critical (I'll be gone in a few mins) than a revert is fine, but if it can wait a few hours we can have this unblocked a bit later.

mmitche · 2023-04-06T23:53:11Z

@lewing to unblock, if I'm not around:

when this build completes, do
Check out this PR branch
darc update-dependencies --id <Bar ID mentioned in the tag in the build>
Push to the PR

I'm 90% sure that will resolve it.

lewing · 2023-04-07T00:14:19Z

@mmitche the arcade build failed

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.4.23206.6 -> To Version 8.0.100-preview.4.23207.4 Dependency coherency updates VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Build,Microsoft.NETCore.App.Runtime.win-x64 From Version 8.0.0-preview.4.23181.2 -> To Version 8.0.0-preview.4.23207.2 (parent: Microsoft.NET.Sdk

…s://github.com/dotnet/installer into darc-main-9eec733a-87d3-4949-9aba-9bf16062934b

mmitche · 2023-04-07T18:07:42Z

@lewing One more attempt

mmitche · 2023-04-07T18:53:08Z

Sigh. It worked, but vstest has a compile error: https://dev.azure.com/dnceng-public/public/_build/results?buildId=231645&view=logs&j=941f2e24-48a0-594a-6b1a-0e16aaeb8606&t=25681878-3d3d-50c4-a78d-b74bb03f4ec7&l=5256

/cc @MichaelSimons

Roll the update back.

MichaelSimons · 2023-04-07T19:02:22Z

Sigh. It worked, but vstest has a compile error: https://dev.azure.com/dnceng-public/public/_build/results?buildId=231645&view=logs&j=941f2e24-48a0-594a-6b1a-0e16aaeb8606&t=25681878-3d3d-50c4-a78d-b74bb03f4ec7&l=5256

/cc @MichaelSimons

Roll the update back.

The arcade-services changes will need to be rolled back as well. The arcade-services changes are tied to the versioning schema of vstest.

MichaelSimons · 2023-04-07T19:18:37Z

@nohwnd - Can you help investigate this source-build failure we are seeing in vstest? This is the first time the arcade services based vstest changes are flowing in.

/vmr/src/vstest/artifacts/source-build/self/src/src/Microsoft.TestPlatform.TestHostProvider/Hosting/DotnetTestHostManager.cs(780,53): error CS8604: Possible null reference argument for parameter 'path1' in 'string Path.Combine(string path1, string path2)'. [/vmr/src/vstest/artifacts/source-build/self/src/src/Microsoft.TestPlatform.TestHostProvider/Microsoft.TestPlatform.TestHostProvider.csproj]

This reverts commit 0bf74dd.

This reverts commit 62e7e22.

This reverts commit e7654dd.

mmitche · 2023-04-07T19:45:19Z

@nohwnd - Can you help investigate this source-build failure we are seeing in vstest? This is the first time the arcade services based vstest changes are flowing in.

/vmr/src/vstest/artifacts/source-build/self/src/src/Microsoft.TestPlatform.TestHostProvider/Hosting/DotnetTestHostManager.cs(780,53): error CS8604: Possible null reference argument for parameter 'path1' in 'string Path.Combine(string path1, string path2)'. [/vmr/src/vstest/artifacts/source-build/self/src/src/Microsoft.TestPlatform.TestHostProvider/Microsoft.TestPlatform.TestHostProvider.csproj]

It looks to be a valid potentially null error. Libary.Path is nullable in .NET 7 and .NET 8.

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.4.23206.6 -> To Version 8.0.100-preview.4.23207.9 Dependency coherency updates VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.ILLink.Tasks,Microsoft.Build,Microsoft.NETCore.App.Runtime.win-x64 From Version 8.0.0-preview.4.23181.2 -> To Version 8.0.0-preview.4.23207.2 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.4.23206.6 -> To Version 8.0.100-preview.4.23207.8 Dependency coherency updates VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Build,Microsoft.NETCore.App.Runtime.win-x64 From Version 8.0.0-preview.4.23181.2 -> To Version 8.0.0-preview.4.23207.2 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.4.23206.6 -> To Version 8.0.100-preview.4.23207.14 Dependency coherency updates VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.ILLink.Tasks,Microsoft.Build,Microsoft.NETCore.App.Runtime.win-x64 From Version 8.0.0-preview.4.23181.2 -> To Version 8.0.0-preview.4.23207.2 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 8.0.100-preview.4.23206.6 -> To Version 8.0.100-preview.4.23207.19 Dependency coherency updates VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.ILLink.Tasks,Microsoft.Build,Microsoft.NETCore.App.Runtime.win-x64 From Version 8.0.0-preview.4.23181.2 -> To Version 8.0.0-preview.4.23207.2 (parent: Microsoft.NET.Sdk

kasperk81 · 2023-04-10T11:23:31Z

vstest was reverted but it's still the same error as last week:

/vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Version.BeforeCommonTargets.targets(54,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression ""23205.10".Substring(9)" cannot be evaluated. startIndex cannot be larger than length of string. (Parameter 'startIndex')

MichaelSimons · 2023-04-10T13:12:21Z

vstest was reverted but it's still the same error as last week:

/vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Version.BeforeCommonTargets.targets(54,5): error MSB4184: (NETCORE_ENGINEERING_TELEMETRY=Restore) The expression ""23205.10".Substring(9)" cannot be evaluated. startIndex cannot be larger than length of string. (Parameter 'startIndex')

The downgraded version didn't for in with this PR - https://github.com/dotnet/installer/pull/16005/files.

kasperk81 · 2023-04-10T13:40:51Z

revert pr was dotnet/sdk#31658 that change is already picked up here. there is nothing else in motion atm. what should be the next step to unblock this pr? (could be a temporary solution to unblock this and block the next one)

MichaelSimons · 2023-04-10T13:46:35Z

revert pr was dotnet/sdk#31658 that change is already picked up here. there is nothing else in motion atm. what should be the next step to unblock this pr? (could be a temporary solution to unblock this and block the next one)

Does Darc not flow downgrades? It is possible the new downgraded vstest needs to be manually updated in this PR. @mmitche

MichaelSimons · 2023-04-10T14:46:15Z

I manually updated the vstest version to match what is in the sdk repo.

lewing · 2023-04-10T15:48:09Z

And it landed, thanks everyone!

mmitche · 2023-04-15T16:56:57Z

Darc does flow downgrades, just won't attempt to auto-merge them.

nagilson enabled auto-merge April 6, 2023 17:56

nagilson approved these changes Apr 6, 2023

View reviewed changes

lewing mentioned this pull request Apr 6, 2023

Wasm.Build.Tests.Blazor.MiscTests.DefaultTemplate_AOT_InProjectFile Test failed dotnet/runtime#84368

Closed

lewing and others added 3 commits April 6, 2023 14:18

Merge branch 'main' into darc-main-9eec733a-87d3-4949-9aba-9bf16062934b

f88ec39

Merge branch 'main' into darc-main-9eec733a-87d3-4949-9aba-9bf16062934b

ab3ab3e

MichaelSimons requested a review from a team as a code owner April 6, 2023 21:01

Remove backported source-build runtime patch

5dae3ba

MichaelSimons mentioned this pull request Apr 6, 2023

Remove vstest special version handling dotnet/arcade-services#2257

Merged

lewing mentioned this pull request Apr 6, 2023

Revert "[main] Update dependencies from microsoft/vstest" dotnet/sdk#31658

Merged

dotnet-maestro bot and others added 3 commits April 7, 2023 17:51

Workaround VMR issues

0bf74dd

Merge branch 'darc-main-9eec733a-87d3-4949-9aba-9bf16062934b' of http…

c13d263

…s://github.com/dotnet/installer into darc-main-9eec733a-87d3-4949-9aba-9bf16062934b

lewing added the Area-Codeflow label Apr 7, 2023

mmitche added 3 commits April 7, 2023 12:21

Revert "Workaround VMR issues"

f2ab5e0

This reverts commit 0bf74dd.

Revert "Update to new darc"

3c3093a

This reverts commit 62e7e22.

Revert "Update to new darclib"

5836540

This reverts commit e7654dd.

dotnet-maestro bot added 4 commits April 7, 2023 20:23

Manually fix vstest version to match sdk

0cd8f55

nagilson merged commit d27c5c5 into main Apr 10, 2023

nagilson deleted the darc-main-9eec733a-87d3-4949-9aba-9bf16062934b branch April 10, 2023 15:47

This was referenced Apr 12, 2023

[main] Update dependencies from dotnet/arcade-services #16069

Closed

[main] Update dependencies from dotnet/sdk #16033

Merged

This was referenced Apr 13, 2023

Check for null Path microsoft/vstest#4391

Merged

Latest vstest builds do not build in sourcebuild with nullability enabled microsoft/vstest#4394

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/sdk #16005

[main] Update dependencies from dotnet/sdk #16005

dotnet-maestro bot commented Apr 6, 2023 •

edited

Loading

dotnet-maestro bot commented Apr 6, 2023

lewing commented Apr 6, 2023

lewing commented Apr 6, 2023 •

edited

Loading

lewing commented Apr 6, 2023

MichaelSimons commented Apr 6, 2023

lewing commented Apr 6, 2023

MichaelSimons commented Apr 6, 2023

lewing commented Apr 6, 2023 •

edited

Loading

MichaelSimons commented Apr 6, 2023

mmitche commented Apr 6, 2023

lewing commented Apr 6, 2023 •

edited

Loading

mmitche commented Apr 6, 2023

mmitche commented Apr 6, 2023

mmitche commented Apr 6, 2023

mmitche commented Apr 6, 2023 •

edited

Loading

lewing commented Apr 7, 2023

mmitche commented Apr 7, 2023

mmitche commented Apr 7, 2023

MichaelSimons commented Apr 7, 2023

MichaelSimons commented Apr 7, 2023

mmitche commented Apr 7, 2023 •

edited

Loading

kasperk81 commented Apr 10, 2023

MichaelSimons commented Apr 10, 2023

kasperk81 commented Apr 10, 2023

MichaelSimons commented Apr 10, 2023

MichaelSimons commented Apr 10, 2023

lewing commented Apr 10, 2023

mmitche commented Apr 15, 2023

[main] Update dependencies from dotnet/sdk #16005

[main] Update dependencies from dotnet/sdk #16005

Conversation

dotnet-maestro bot commented Apr 6, 2023 • edited Loading

From https://github.com/dotnet/sdk

Coherency Updates

dotnet-maestro bot commented Apr 6, 2023

Notification for subscribed users from https://github.com/dotnet/sdk:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

lewing commented Apr 6, 2023

lewing commented Apr 6, 2023 • edited Loading

lewing commented Apr 6, 2023

MichaelSimons commented Apr 6, 2023

lewing commented Apr 6, 2023

MichaelSimons commented Apr 6, 2023

lewing commented Apr 6, 2023 • edited Loading

MichaelSimons commented Apr 6, 2023

mmitche commented Apr 6, 2023

lewing commented Apr 6, 2023 • edited Loading

mmitche commented Apr 6, 2023

mmitche commented Apr 6, 2023

mmitche commented Apr 6, 2023

mmitche commented Apr 6, 2023 • edited Loading

lewing commented Apr 7, 2023

mmitche commented Apr 7, 2023

mmitche commented Apr 7, 2023

MichaelSimons commented Apr 7, 2023

MichaelSimons commented Apr 7, 2023

mmitche commented Apr 7, 2023 • edited Loading

kasperk81 commented Apr 10, 2023

MichaelSimons commented Apr 10, 2023

kasperk81 commented Apr 10, 2023

MichaelSimons commented Apr 10, 2023

MichaelSimons commented Apr 10, 2023

lewing commented Apr 10, 2023

mmitche commented Apr 15, 2023

dotnet-maestro bot commented Apr 6, 2023 •

edited

Loading

lewing commented Apr 6, 2023 •

edited

Loading

lewing commented Apr 6, 2023 •

edited

Loading

lewing commented Apr 6, 2023 •

edited

Loading

mmitche commented Apr 6, 2023 •

edited

Loading

mmitche commented Apr 7, 2023 •

edited

Loading