Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/arcade-services #16069

Closed

Conversation

dotnet-maestro[bot]
Copy link

@dotnet-maestro dotnet-maestro bot commented Apr 12, 2023

This pull request updates the following dependencies

From https://github.com/dotnet/arcade-services

  • Subscription: 477fae42-a521-40a1-cb02-08da841b78da
  • Build: 20230412.1
  • Date Produced: April 12, 2023 12:28:42 PM UTC
  • Commit: 93a00e5b861eb9c3d0448639b1a1cef2176793e3
  • Branch: refs/heads/main

@premun premun self-requested a review April 12, 2023 09:19
@premun
Copy link
Member

premun commented Apr 12, 2023

This is waiting on dotnet/arcade-services#2259

@premun
Copy link
Member

premun commented Apr 12, 2023

@MichaelSimons @mmitche this will bring in the new vstest versioning change. Should we also bump vstest in this PR to go with it so that the versioning is correct?

@MichaelSimons
Copy link
Member

@MichaelSimons @mmitche this will bring in the new vstest versioning change. Should we also bump vstest in this PR to go with it so that the versioning is correct?

We will need to bump vstest in order for the source-build CI to pass. I expect vstest will fail as we saw earlier in #16005 (comment).

…ild 20230410.1

Microsoft.DotNet.Darc , Microsoft.DotNet.DarcLib
 From Version 1.1.0-beta.23128.1 -> To Version 1.1.0-beta.23210.1
…ild 20230412.1

Microsoft.DotNet.Darc , Microsoft.DotNet.DarcLib
 From Version 1.1.0-beta.23128.1 -> To Version 1.1.0-beta.23212.1
@premun premun force-pushed the darc-main-11491d01-3288-41b7-8418-3a9cab7a2f13 branch from 10ef05b to 6a3a2f9 Compare April 12, 2023 13:08
@premun
Copy link
Member

premun commented Apr 12, 2023

@MichaelSimons I found out today that someone wrongly reverted code and reverted quite a few commits from the VMR tooling while I was away. This has been fixed and the build here is now passing. So I think we should merge this and we will be ready for the new versioning from vstest once it comes.

@MichaelSimons
Copy link
Member

If this new arcade-services version contains the versioning fix for vstest it can't be merged in without the corresponding vstest changes otherwise it will break the build. The two are coupled. If you want to break the coupling the version logic will have to be refactored to handle both vstest versioning patterns.

@premun
Copy link
Member

premun commented Apr 12, 2023

I think it would only break when there would be some other vstest commit coming in that would still have the old versioning.

But yeah, let's bump DarcLib once we are flowing the new vstest then.

@premun premun closed this Apr 12, 2023
@premun premun deleted the darc-main-11491d01-3288-41b7-8418-3a9cab7a2f13 branch April 12, 2023 14:21
@mmitche
Copy link
Member

mmitche commented Apr 12, 2023

We should trigger vstest into main (sdk) then, and then we can do update-dependencies on that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants