Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow .lss binaries for all repos #17028

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

mthalman
Copy link
Member

The Scan for binaries job for the VMR is detecting a binary in the msbuild repo:

src/msbuild/eng/common/loc/P22DotNetHtmlLocalization.lss

This was introduced by dotnet/msbuild#8672.

We already have an allowance for this for the emsdk repo. So I've generalized this to be applicable for all repos.

@mthalman mthalman requested a review from premun July 20, 2023 12:54
@mthalman mthalman requested a review from a team as a code owner July 20, 2023 12:54
@mthalman mthalman enabled auto-merge (squash) July 20, 2023 13:10
@mthalman mthalman merged commit 78cf78c into dotnet:main Jul 20, 2023
@mthalman mthalman deleted the msbuild-binary branch July 20, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants