Update to Arcade 8 #8672

rainersigwald · 2023-04-17T19:05:15Z

Make IDE0251 a suggestion
Arcade 8
Put expected and actual in the right places for some tlbimp tests
Explicit System.IO.Compression reference

It fires in some very funky places like Dispose methods where it's not _wrong_ but it would be _weird_.

JanKrivanek · 2023-04-19T07:19:19Z

Naive question - can the eng\common* changes associated with the arcade update be made as a maestro flow PR from arcade? (with all other fixes needed for it to go through to be added to that PR)

At least those changes comes from arcade (are not msbuild specific) and hence do not need to be reviewed in detail - is that correct?

rainersigwald · 2023-04-19T14:49:44Z

I generated the big change in this PR with a darc update-dependencies command that does locally what the darc subscriptions would create a PR for--I expected this change to break so I didn't want to change the subscription and break our 6.0 flow. You're right that eng/common/* belongs to Arcade and doesn't need much in the way of review.

But this is broken so don't review it at all yet :)

JaynieBai · 2023-06-28T08:25:34Z

/azp run

azure-pipelines · 2023-06-28T08:25:39Z

Pull request contains merge conflicts.

JanKrivanek · 2023-07-07T11:43:46Z

@ViktorHofer we are trying to update MSBuild TFM and Arcade version both to net8.0 and currently we are stuck at

##[error].dotnet\sdk\8.0.100-preview.3.23178.7\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ApiCompat.ValidatePackage.targets(39,5): error PKV006: (NETCORE_ENGINEERING_TELEMETRY=Build) Target framework net7.0 is no longer supported in the latest version..

Should we temporarily disable the package validation, produce a successfull build (targetting net8.0) and then point baseline to that successfull build? Or is there alternative suggestion how to satisfy baseline validation check with our current baseline (targetting net7.0)?

FYI @JaynieBai, @GangWang01

ViktorHofer · 2023-07-10T13:42:29Z

Should we temporarily disable the package validation, produce a successfull build (targetting net8.0) and then point baseline to that successfull build? Or is there alternative suggestion how to satisfy baseline validation check with our current baseline (targetting net7.0)?

This is telling you that you are dropping a TFM in your packages which is considered a breaking change. If that's intentional, you can suppress these errors by updating the suppression file via the following flag: dotnet build /p:GenerateCompatibilitySuppressionFile=true. Note that with .NET 7, the flag got renamed to dotnet build /p:ApiCompatGenerateSuppressionFile=true but the old one still works.

Note that you could also NoWarn the error but that would disable the validation entirely for all TFM changes.

JanKrivanek

Looks good to go to me

It seems that only missing changes to satisfy the #8969 as well are updates to readmes:

src/Framework/README.md
src/Utilities/README.md

It's a minimal and nonfunctional change - please bundle it into this PR

src/Build/CompatibilitySuppressions.xml

…to arcade8

Directory.Build.props

global.json

src/Utilities/README.md

src/Build/CompatibilitySuppressions.xml

global.json

GangWang01 · 2023-07-13T11:00:42Z

After I pushed the commit that resolved review comment, the new run failed. So I reverted the commit back. The run still failed with the error below. I'm looking into it.

stage1\bin\bootstrap\net8.0\MSBuild\NuGet.RestoreEx.targets#L19
stage1\bin\bootstrap\net8.0\MSBuild\NuGet.RestoreEx.targets(19,5): error : (NETCORE_ENGINEERING_TELEMETRY=Restore) Static graph-based restore encountered an unhandled exception. Please file an issue at https://github.com/NuGet/Home.  The exception was:
System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
File name: 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
   at NuGet.Build.Tasks.Console.MSBuildStaticGraphRestore..ctor(Boolean debug)
   at NuGet.Build.Tasks.Console.Program.Main(String[] args)

JanKrivanek · 2023-07-13T16:40:23Z

After I pushed the commit that resolved review comment, the new run failed. So I reverted the commit back. The run still failed with the error below. I'm looking into it.

stage1\bin\bootstrap\net8.0\MSBuild\NuGet.RestoreEx.targets#L19
stage1\bin\bootstrap\net8.0\MSBuild\NuGet.RestoreEx.targets(19,5): error : (NETCORE_ENGINEERING_TELEMETRY=Restore) Static graph-based restore encountered an unhandled exception. Please file an issue at https://github.com/NuGet/Home.  The exception was:
System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
File name: 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
   at NuGet.Build.Tasks.Console.MSBuildStaticGraphRestore..ctor(Boolean debug)
   at NuGet.Build.Tasks.Console.Program.Main(String[] args)

Looks like clash with #8856

…useless property setting

global.json

rainersigwald

I can't formally approve because I started the PR but this looks good to me, let's get it in on Monday @rokonec :)

* Make IDE0251 a suggestion It fires in some very funky places like Dispose methods where it's not _wrong_ but it would be _weird_. * Put expected and actual in the right places for some tlbimp tests * Explicit System.IO.Compression reference on framework * Suppress the error PKV006 for Net 7.0, since we're intentionally dropping it Co-authored-by: Jenny Bai <v-jennybai@microsoft.com> Co-authored-by: Gang Wang <v-gaw@microsoft.com>

rainersigwald added 5 commits April 17, 2023 13:53

Make IDE0251 a suggestion

77745c4

It fires in some very funky places like Dispose methods where it's not _wrong_ but it would be _weird_.

Arcade 8

55a6832

Put expected and actual in the right places for some tlbimp tests

8ed1d4b

Explicit System.IO.Compression reference

0983ad8

download 7 runtime

a54e08e

JanKrivanek mentioned this pull request Jun 21, 2023

[main] Update dependencies from dotnet/source-build-reference-packages #8893

Merged

JanKrivanek assigned JaynieBai Jun 28, 2023

JaynieBai added 3 commits June 28, 2023 16:52

Merge branch 'main' into arcade8

1a0249f

Update the net7.0 path to net8.0

9e08beb

Update source prebuild baseline

7c8e69f

JaynieBai added 2 commits July 11, 2023 12:28

Suppress the error PKV006 for Net 7.0 temporally

cace149

suppress PKV006 for Net7.0

7a98402

JanKrivanek approved these changes Jul 11, 2023

View reviewed changes

JanKrivanek marked this pull request as ready for review July 11, 2023 06:29

Update doc to net8.0

f94059f

GangWang01 mentioned this pull request Jul 11, 2023

Update to net8.0 #8996

Closed

ViktorHofer reviewed Jul 11, 2023

View reviewed changes

src/Build/CompatibilitySuppressions.xml Outdated Show resolved Hide resolved

JaynieBai added 2 commits July 12, 2023 11:43

Add doc header

963331c

Merge branch 'arcade8' of https://github.com/rainersigwald/msbuild in…

1aa2d03

…to arcade8

ViktorHofer reviewed Jul 12, 2023

View reviewed changes

Directory.Build.props Outdated Show resolved Hide resolved

ViktorHofer reviewed Jul 12, 2023

View reviewed changes

global.json Show resolved Hide resolved

GangWang01 self-assigned this Jul 12, 2023

rainersigwald commented Jul 12, 2023

View reviewed changes

src/Utilities/README.md Outdated Show resolved Hide resolved

src/Build/CompatibilitySuppressions.xml Show resolved Hide resolved

global.json Show resolved Hide resolved

rainersigwald mentioned this pull request Jul 12, 2023

[main] Update dependencies from dotnet/arcade #9020

Closed

GangWang01 force-pushed the arcade8 branch 2 times, most recently from 35b7fa8 to 1aa2d03 Compare July 13, 2023 09:35

GangWang01 added 2 commits July 14, 2023 09:35

Update runtime to 8.0

0941c56

Add the comment for adding PKV006 suppression; update doc and remove …

d7215c6

…useless property setting

ViktorHofer reviewed Jul 14, 2023

View reviewed changes

global.json Outdated Show resolved Hide resolved

Remove specific runtime version

5d69186

rainersigwald commented Jul 14, 2023

View reviewed changes

rainersigwald enabled auto-merge (squash) July 14, 2023 15:32

ViktorHofer approved these changes Jul 14, 2023

View reviewed changes

rainersigwald merged commit 1e7d9a4 into dotnet:main Jul 14, 2023

rainersigwald deleted the arcade8 branch July 14, 2023 16:24

mthalman mentioned this pull request Jul 20, 2023

Allow .lss binaries for all repos dotnet/installer#17028

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to Arcade 8 #8672

Update to Arcade 8 #8672

rainersigwald commented Apr 17, 2023 •

edited by JanKrivanek

Loading

JanKrivanek commented Apr 19, 2023

rainersigwald commented Apr 19, 2023

JaynieBai commented Jun 28, 2023

azure-pipelines bot commented Jun 28, 2023

JanKrivanek commented Jul 7, 2023

ViktorHofer commented Jul 10, 2023 •

edited

Loading

JanKrivanek left a comment •

edited

Loading

GangWang01 commented Jul 13, 2023

JanKrivanek commented Jul 13, 2023

rainersigwald left a comment

Update to Arcade 8 #8672

Update to Arcade 8 #8672

Conversation

rainersigwald commented Apr 17, 2023 • edited by JanKrivanek Loading

JanKrivanek commented Apr 19, 2023

rainersigwald commented Apr 19, 2023

JaynieBai commented Jun 28, 2023

azure-pipelines bot commented Jun 28, 2023

JanKrivanek commented Jul 7, 2023

ViktorHofer commented Jul 10, 2023 • edited Loading

JanKrivanek left a comment • edited Loading

Choose a reason for hiding this comment

GangWang01 commented Jul 13, 2023

JanKrivanek commented Jul 13, 2023

rainersigwald left a comment

Choose a reason for hiding this comment

rainersigwald commented Apr 17, 2023 •

edited by JanKrivanek

Loading

ViktorHofer commented Jul 10, 2023 •

edited

Loading

JanKrivanek left a comment •

edited

Loading