New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add custom kernel picker #2379

Merged

brettfo merged 1 commit into dotnet:main from brettfo:dynamic-kernel

Nov 23, 2022

Member

brettfo commented Oct 25, 2022 •

edited

Loading

I HIGHLY recommend you pull this down and test it locally. Once you checkout the branch, run git clean -dxf because there will be issues if you have stale artifacts sitting around. When you run it you'll need to set both the kernelTransportArgs as well as notebookParserArgs to point to the local build, because both of those have changes.

before merging, restore the package source URL in insiders package.json.

Fixes #1302

brettfo requested review from colombod and jonsequitur

October 25, 2022 23:47

brettfo force-pushed the dynamic-kernel branch 11 times, most recently from 4eebd8a to f2db3c4 Compare

October 27, 2022 22:30

brettfo force-pushed the dynamic-kernel branch from f2db3c4 to f462e4c Compare

November 3, 2022 22:59

jonsequitur reviewed

View reviewed changes

...ive.ApiCompatibility.Tests/ApiCompatibilityTests.Interactive_api_is_not_changed.approved.txt Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

src/Microsoft.DotNet.Interactive.Documents.Tests/DocumentFormatTestsBase.cs Outdated Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

src/Microsoft.DotNet.Interactive.Documents/CodeSubmission.cs Outdated Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

src/Microsoft.DotNet.Interactive.Documents/ParserServer/NotebookParserServer.cs Outdated Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

src/Microsoft.DotNet.Interactive.Journey/NotebookLessonParser.cs Outdated Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

src/Microsoft.DotNet.Interactive.Jupyter.Tests/CompleteRequestHandlerTests.cs Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

src/Microsoft.DotNet.Interactive.Jupyter.Tests/CompleteRequestHandlerTests.cs Outdated Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

src/Microsoft.DotNet.Interactive.Jupyter.Tests/CompleteRequestHandlerTests.cs Outdated Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

src/Microsoft.DotNet.Interactive.Jupyter.Tests/CustomMetadataParsingTests.cs Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

src/Microsoft.DotNet.Interactive.Jupyter.Tests/CustomMetadataParsingTests.cs Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

src/Microsoft.DotNet.Interactive.Jupyter.Tests/CustomMetadataParsingTests.cs Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

src/Microsoft.DotNet.Interactive.Jupyter.Tests/ExecuteRequestHandlerTests.cs Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

src/Microsoft.DotNet.Interactive.Jupyter.Tests/IsCompleteRequestHandlerTests.cs Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

src/Microsoft.DotNet.Interactive.Jupyter.Tests/JupyterMessageContractTests.cs Outdated Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

src/Microsoft.DotNet.Interactive.Jupyter.Tests/IsCompleteRequestHandlerTests.cs Outdated Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

src/Microsoft.DotNet.Interactive.Jupyter.Tests/IsCompleteRequestHandlerTests.cs Outdated Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

src/dotnet-interactive-vscode-common/src/metadataUtilities.ts Show resolved Hide resolved

jonsequitur reviewed

View reviewed changes

src/dotnet-interactive-vscode-common/tests/kernelSelectorUtilities.test.ts Outdated Show resolved Hide resolved

brettfo force-pushed the dynamic-kernel branch from 5391fa2 to 87a3aaf Compare

November 17, 2022 00:43

brettfo linked an issue

that may be closed by this pull request

kernel picker not showing aliased name #2438

Closed

brettfo added the Area-Polyglot Notebooks Extension label

brettfo force-pushed the dynamic-kernel branch 4 times, most recently from 7631bba to 0e90043 Compare

November 23, 2022 00:45

brettfo marked this pull request as ready for review

November 23, 2022 00:47

brettfo enabled auto-merge (squash)

November 23, 2022 00:48

brettfo disabled auto-merge

November 23, 2022 01:08

colombod approved these changes

View reviewed changes

brettfo force-pushed the dynamic-kernel branch from 0e90043 to 1f3830a Compare

November 23, 2022 01:24

brettfo enabled auto-merge (squash)

November 23, 2022 01:25


          add custom kernel picker

35d0e6b

brettfo force-pushed the dynamic-kernel branch from 1f3830a to 35d0e6b Compare

November 23, 2022 02:59

brettfo merged commit eee2c78 into dotnet:main

brettfo deleted the dynamic-kernel branch

November 23, 2022 03:40

brettfo mentioned this pull request

Section 508 502.3.1: (Code/document '') The Name property of a focusable element must not be null. #2446

Closed

brettfo linked an issue

that may be closed by this pull request

mermaid and HTML should not be options in sharing kernel list #2408

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Polyglot Notebooks Extension