Skip to content

[generator] Use an ILookup for better performance. #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonpryor merged 2 commits into from
Jun 28, 2019
Merged

[generator] Use an ILookup for better performance. #440

jonpryor merged 2 commits into from
Jun 28, 2019

Conversation

@jpobst
Copy link
Contributor

@jpobst jpobst commented Jun 28, 2019

Using an ILookup instead of constantly recalculating this IEnumerable causes this step duration to drop from ~30s generating Mono.Android.dll to ~0.3s.

@jpobst jpobst requested a review from jonpryor June 28, 2019 14:25
@jonpryor jonpryor merged commit 35b0ce8 into master Jun 28, 2019
@jpobst jpobst deleted the generator-ilookup branch June 28, 2019 18:37
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jonpryor jonpryor Awaiting requested review from jonpryor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

10.1 (d16-4)

Development

Successfully merging this pull request may close these issues.

4 participants

@jpobst @jonpryor @brendanzagaeski