Skip to content

[generator] Use an ILookup for better performance. #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonpryor merged 2 commits into from
Jun 28, 2019
Merged

[generator] Use an ILookup for better performance. #440

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a1f7fc
[generator] Use an ILookup for better performance.
jpobst Jun 28, 2019
a67ab60
Fix whitespace
jonpryor Jun 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/generator/ApiVersionsSupport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ static IEnumerable<GenBase> FlattenGens (IEnumerable<GenBase> gens)

public static void AssignApiLevels (IList<GenBase> gens, string apiVersionsXml)
{
var flattenGens = FlattenGens (gens);
var flattenGens = FlattenGens (gens).ToLookup (g => g.JavaName);
var versions = new ApiVersionsProvider ();
versions.Parse (apiVersionsXml);
foreach (var type in versions.Versions.Values) {
var matchedGens = flattenGens.Where (g => g.JavaName == type.Name);
var matchedGens = flattenGens [type.Name];
if (!matchedGens.Any ())
// There are known missing types, and it's going to be too noisy to report missing ones here.
// That task should be done elsewhere.
Expand Down