Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround NRE in SweepStep #2264

Merged
merged 5 commits into from
Sep 8, 2021

Conversation

vitek-karas
Copy link
Member

Basically a workaround for #2260. This simply goes back to using the Resolve method and avoid the cache for now.

Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

src/linker/Linker.Steps/SweepStep.cs Outdated Show resolved Hide resolved
src/linker/Linker.Steps/SweepStep.cs Show resolved Hide resolved
Basically a workaround for dotnet#2260. This simply goes back to using the `Resolve` method and avoid the cache for now.
@vitek-karas vitek-karas merged commit a9888c2 into dotnet:main Sep 8, 2021
@vitek-karas vitek-karas deleted the WorkaroundNREInSweep branch September 8, 2021 09:14
agocke pushed a commit to dotnet/runtime that referenced this pull request Nov 16, 2022
Basically a workaround for dotnet/linker#2260. This simply goes back to using the `Resolve` method and avoid the cache for now.

Commit migrated from dotnet/linker@a9888c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants