Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from mono/linker #58436

Merged
merged 10 commits into from
Sep 11, 2021
Merged

[main] Update dependencies from mono/linker #58436

merged 10 commits into from
Sep 11, 2021

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 31, 2021 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/mono/linker

  • Subscription: 0d6d6ae4-f71f-4395-53e6-08d8e409d87d
  • Build: 20210910.1
  • Date Produced: 9/10/2021 9:09 AM
  • Commit: 0c359eadea75bde0de74d784fdc45788b3668e73
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210830.7
878aeb0 
Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-alpha.1.21426.2 -> To Version 7.0.100-alpha.1.21430.7
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Aug 31, 2021
@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210831.1
9e29679 
Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-alpha.1.21426.2 -> To Version 7.0.100-alpha.1.21431.1
@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210902.3
bcb3aff 
Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-alpha.1.21426.2 -> To Version 7.0.100-alpha.1.21452.3
@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210902.5
96ed2c9 
Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-alpha.1.21426.2 -> To Version 7.0.100-alpha.1.21452.5
@lewing
Copy link
Member

lewing commented Sep 4, 2021 

D:\workspace\_work\1\s\src\libraries\System.Reflection.Context\src\System\Reflection\Context\Delegation\DelegatingAssembly.cs(27,32): error IL3003:  [D:\workspace\_work\1\s\src\libraries\System.Reflection.Context\src\System.Reflection.Context.csproj]
##[error]src\libraries\System.Reflection.Context\src\System\Reflection\Context\Delegation\DelegatingAssembly.cs(27,32): error IL3003: (NETCORE_ENGINEERING_TELEMETRY=Build)

@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210903.3
17a5543 
Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-alpha.1.21426.2 -> To Version 7.0.100-alpha.1.21453.3
@marek-safar
Copy link
Contributor

marek-safar commented Sep 6, 2021 •
edited
Loading

There is not crash in linker due to NRE, which I suspect is from @sbomer nullability changes.

     at Mono.Cecil.DefaultMetadataImporter.ImportScope(IMetadataScope scope)
     at Mono.Cecil.DefaultMetadataImporter.ImportScope(TypeReference type)
     at Mono.Cecil.DefaultMetadataImporter.ImportType(TypeReference type, ImportGenericContext context)
     at Mono.Cecil.DefaultMetadataImporter.ImportReference(TypeReference type, IGenericParameterProvider context)
     at Mono.Cecil.ModuleDefinition.ImportReference(TypeReference type, IGenericParameterProvider context)
     at Mono.Cecil.ModuleDefinition.ImportReference(TypeReference type)
     at Mono.Linker.Steps.SweepStep.AssemblyReferencesCorrector.UpdateScopeOfTypeReference(TypeReference type)

/cc @vitek-karas

@vitek-karas
Copy link
Member

The failure is caused by dotnet/linker#2234. I don't know exactly why yet.

@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210906.1
7acf604 
Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-alpha.1.21426.2 -> To Version 7.0.100-1.21456.1
@vitek-karas
Copy link
Member

The root cause of this failure is actually quite complex. I filed dotnet/linker#2260 to track this. I'll try to figure out a simple workaround to unblock runtime integration and we'll work on the real fix after that.

@vitek-karas
Copy link
Member

The workaround for this issue is in this linker PR dotnet/linker#2264. Once it's merged it should auto-update this PR to pick it up.

@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210906.3
0801b44 
Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-alpha.1.21426.2 -> To Version 7.0.100-1.21456.3
@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210908.2
bb0943e 
Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-alpha.1.21426.2 -> To Version 7.0.100-1.21458.2
@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210908.4
54a6f61 
Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-alpha.1.21426.2 -> To Version 7.0.100-1.21458.4
@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210910.1
d423eee 
Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-alpha.1.21426.2 -> To Version 7.0.100-1.21460.1
@akoeplinger akoeplinger merged commit ad0c361 into main Sep 11, 2021
@akoeplinger akoeplinger deleted the darc-main-cad2c2d0-08ca-46c8-bda9-6e560c2db0fe branch September 11, 2021 10:26
@ghost ghost locked as resolved and limited conversation to collaborators Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vitek-karas vitek-karas vitek-karas approved these changes

@agocke agocke Awaiting requested review from agocke

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lewing @marek-safar @vitek-karas @akoeplinger