Add a test which uncovered stack overflow in 7.0 #3156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recurisve generics with interface marking annotation used to cause stackoverflow in the linker. The test now passes since the problem was fixed in dotnet#3073
|
I verified that with #3094 the test passes as well. |
|
Once merged we should add this test to #3094 as well. |
marek-safar
approved these changes
Dec 9, 2022
vitek-karas
added a commit
to jtschuster/linker
that referenced
this pull request
Dec 12, 2022
This is a copy of the test added in dotnet#3156
tlakollo
pushed a commit
to tlakollo/linker
that referenced
this pull request
Dec 20, 2022
Recurisve generics with interface marking annotation used to cause stackoverflow in the linker. The test now passes since the problem was fixed in dotnet#3073 Commit migrated from dotnet@dde6d62
tlakollo
pushed a commit
to tlakollo/runtime
that referenced
this pull request
Dec 22, 2022
Recurisve generics with interface marking annotation used to cause stackoverflow in the linker. The test now passes since the problem was fixed in dotnet/linker#3073 Commit migrated from dotnet/linker@dde6d62
sbomer
added a commit
that referenced
this pull request
Jan 18, 2023
…state changes (#3094) * Check for marking virtual method due to base only when state changes (#3073) Instead of checking every virtual method to see if it should be kept due to a base method every iteration of the MarkStep pipeline, check each method only when its relevant state has changed. Co-authored-by: Sven Boemer <sbomer@gmail.com> * Don't mark override of abstract base if the override's declaring type is not marked (#3098) * Don't mark an override every time the base is abstract, only if the declaring type is also marked Adds a condition to ShouldMarkOverrideForBase to exit early if the declaring type of the method is not marked. * Add test case for #3112 with pseudo-circular reference with ifaces * Link issue to TODO * Adds a test for recursive generics on interfaces This is a copy of the test added in #3156 Co-authored-by: Sven Boemer <sbomer@gmail.com> Co-authored-by: vitek-karas <10670590+vitek-karas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recursive generics with interface marking annotation used to cause stackoverflow in the linker. The test now passes since the problem was fixed in #3073
This seems to be the test for #3155 - it produces the exact same stack frames and stack overflow when ran on 7.0.