Add search dir where Windows.winmd can be found #343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the fix merged in dotnet#340 many unit tests now need to be able to resolve Windows.winmd when linking against .NET Class libraries.
|
@marek-safar Any feelings on which approach to take for fixing the .NET Core build due to the inclusion of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the fix merged in #340 many unit tests now need to be able to resolve Windows.winmd when linking against .NET Framework class libraries. This is happening because a GetType of
System.Runtime.WindowsRuntime, System.Resources.WindowsRuntimeResourceManagerthat was previously not handled is now handled. Bringing inSystem.Runtime.WindowsRuntimeeventually leads to trying to resolveWindowswhich fails.I'm not sure if this is the best way of resolving Windows.winmd. I copied the logic from what we do in UnityLinker for our windows runtime support and it worked. It does seem a little fragile given that the logic expects a specific version directory. But if it works I'm happy.
If you know of a more robust way to locate windows.winmd I'm happy to change it.