Include a fixed GenerateDepsFile task #479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are taken from https://github.com/dotnet/sdk, at version c7ae732f33f88b05aac42b3554f32c6ec6f96148. These files will be used temporarily to build a replacement for the GenerateDepsFile task that fixes trimming (see dotnet/sdk#3010).
Keep the "./" prefix in deps.json for runtime pack assets. The corresponding fix in the host doesn't seem to be in the latest preview yet, so this will enable running with the latest preview. See dotnet/sdk@04c155f.
This works around dotnet/sdk#3010
|
The SDK is getting a fix once dotnet/sdk#3086 makes it in to master via dotnet/sdk#3113. In the meantime, #483 includes a GenerateDepsFile task with my workaround for the purposes of running integration tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around a bug in the SDK's deps file generation logic: dotnet/sdk#3010. I'm building ILLink.Tasks with a copy of the sources used by the SDK to generate deps files. It's a temporary replacement for the GenerateDepsFile task, with a fix for the issue mentioned above in 39a6ae7. I intend to remove it as soon as the SDK issue is fixed. I'm doing this mostly to get our integration tests up and running in the interim - I definitely don't want to ship this fix in the SDK.
@nguerrera