[nomerge] Fix integration tests #483
Closed
+1,105
−356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbomer
force-pushed
the
fixIntegrationTests
branch
8 times, most recently
from
33f802a to
48b2489
Compare
sbomer
force-pushed
the
fixIntegrationTests
branch
3 times, most recently
from
a01e2f3 to
d9ebe01
Compare
sbomer
force-pushed
the
fixIntegrationTests
branch
3 times, most recently
from
792ff6e to
bd82bcc
Compare
Instead of restoring the locally-built nuget package. This more closely matches how the linker will be used in the future, since it is being included in the SDK rather than through PackageReferences.
This was not working on windows, and according to the docs should never have worked on OSX. See https://github.com/dotnet/corefx/issues/36713.
Also use lowercase arguments on unix for consistency. The scripts accept case-insensitive args, but use lowercase args themselves.
Instead of injecting the path to the tasks dll, the tests now inject the path to a directory that contains each TFM-specific implementation. It then imports the same Sdk.props that are imported by the SDK. The tests now contain a local version of the SDK targets, to facilitate testing in a way that matches the SDK behavior as closely as possible while using a local build of the task dll.
Defaults are now assembly-level trimming
Also get rid of Sdk props import hook. This is no longer necessary because the SDK comes with a version of Sdk.props that reads _ILLinkTasksDirectoryRoot.
sbomer
force-pushed
the
fixIntegrationTests
branch
from
509f059 to
ed2a6bb
Compare
System.Private.CoreLib was recently modified and no longer has an AssemblyDescriptionAttribute, but it should be added back. Disable tests that fail due to this until it is added back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the integration tests to work with the recent directory layout change, using the 3.0 SDK (it depends on #478).
The MusicStore tests have been disabled for now due to aspnet/JitBench#96.