removing extraneous character that broke the linux build, and with it the unnecessary cmake version requirement

[sfilipi]

The cmake file for the FactorizationMachineNative folder contained a character in the first line, that was causing the build to fail.

Deleting that, and deleting the first line, which was requiring a version of cmake higher than 3.2.

There are no issues with this PR, as this is to fix the Linux build.

[eerhardt]

Looks good. Thanks for taking care of this @sfilipi !

[eerhardt]

I just checked out the build, and it is still failing:

2018-06-27T03:32:36.5972284Z   /_work/10/s/src/Native/FactorizationMachineNative/CMakeLists.txt:1:
2018-06-27T03:32:36.6003873Z   Parse error.  Expected a command name, got unquoted argument with text "project".

Does the file have a certain kind of encoding on it? Does it have a BOM?

[justinormont]

I see a BOM on the file (0xEF, 0xBB, 0xBF).

$ hexdump -C CMakeLists.txt
00000000  ef bb bf 70 72 6f 6a 65  63 74 20 28 46 61 63 74  |...project (Fact|
00000010  6f 72 69 7a 61 74 69 6f  6e 4d 61 63 68 69 6e 65  |orizationMachine|
00000020  4e 61 74 69 76 65 29 0a  0a 73 65 74 28 53 4f 55  |Native)..set(SOU|
00000030  52 43 45 53 0a 20 20 20  20 46 61 63 74 6f 72 69  |RCES.    Factori|
00000040  7a 61 74 69 6f 6e 4d 61  63 68 69 6e 65 43 6f 72  |zationMachineCor|
00000050  65 2e 63 70 70 0a 29 0a  0a 69 66 28 57 49 4e 33  |e.cpp.)..if(WIN3|
00000060  32 29 0a 65 6c 73 65 28  29 0a 20 20 20 20 6c 69  |2).else().    li|
00000070  73 74 28 41 50 50 45 4e  44 20 53 4f 55 52 43 45  |st(APPEND SOURCE|
00000080  53 20 24 7b 56 45 52 53  49 4f 4e 5f 46 49 4c 45  |S ${VERSION_FILE|
00000090  5f 50 41 54 48 7d 29 0a  65 6e 64 69 66 28 29 0a  |_PATH}).endif().|
000000a0  0a 61 64 64 5f 6c 69 62  72 61 72 79 28 46 61 63  |.add_library(Fac|
000000b0  74 6f 72 69 7a 61 74 69  6f 6e 4d 61 63 68 69 6e  |torizationMachin|
000000c0  65 4e 61 74 69 76 65 20  53 48 41 52 45 44 20 24  |eNative SHARED $|
000000d0  7b 53 4f 55 52 43 45 53  7d 20 24 7b 52 45 53 4f  |{SOURCES} ${RESO|
000000e0  55 52 43 45 53 7d 29 0a  0a 69 6e 73 74 61 6c 6c  |URCES})..install|
000000f0  5f 6c 69 62 72 61 72 79  5f 61 6e 64 5f 73 79 6d  |_library_and_sym|
00000100  62 6f 6c 73 20 28 46 61  63 74 6f 72 69 7a 61 74  |bols (Factorizat|
00000110  69 6f 6e 4d 61 63 68 69  6e 65 4e 61 74 69 76 65  |ionMachineNative|
00000120  29                                                |)|
00000121

[sfilipi]

It builds fine locally.. Taking a look. From: Justin Ormont <notifications@github.com> Sent: Wednesday, June 27, 2018 5:09 AM To: dotnet/machinelearning <machinelearning@noreply.github.com> Cc: Senja Filipi <sefilipi@microsoft.com>; Mention <mention@noreply.github.com> Subject: Re: [dotnet/machinelearning] removing extraneous character that broke the linux build, and with it the unnecessary cmake version requirement (#425) I see a BOM on the file (0xEF, 0xBB, 0xBF). $ hexdump -C CMakeLists.txt 00000000 ef bb bf 70 72 6f 6a 65 63 74 20 28 46 61 63 74 |...project (Fact| 00000010 6f 72 69 7a 61 74 69 6f 6e 4d 61 63 68 69 6e 65 |orizationMachine| 00000020 4e 61 74 69 76 65 29 0a 0a 73 65 74 28 53 4f 55 |Native)..set(SOU| 00000030 52 43 45 53 0a 20 20 20 20 46 61 63 74 6f 72 69 |RCES. Factori| 00000040 7a 61 74 69 6f 6e 4d 61 63 68 69 6e 65 43 6f 72 |zationMachineCor| 00000050 65 2e 63 70 70 0a 29 0a 0a 69 66 28 57 49 4e 33 |e.cpp.)..if(WIN3| 00000060 32 29 0a 65 6c 73 65 28 29 0a 20 20 20 20 6c 69 |2).else(). li| 00000070 73 74 28 41 50 50 45 4e 44 20 53 4f 55 52 43 45 |st(APPEND SOURCE| 00000080 53 20 24 7b 56 45 52 53 49 4f 4e 5f 46 49 4c 45 |S ${VERSION_FILE| 00000090 5f 50 41 54 48 7d 29 0a 65 6e 64 69 66 28 29 0a |_PATH}).endif().| 000000a0 0a 61 64 64 5f 6c 69 62 72 61 72 79 28 46 61 63 |.add_library(Fac| 000000b0 74 6f 72 69 7a 61 74 69 6f 6e 4d 61 63 68 69 6e |torizationMachin| 000000c0 65 4e 61 74 69 76 65 20 53 48 41 52 45 44 20 24 |eNative SHARED $| 000000d0 7b 53 4f 55 52 43 45 53 7d 20 24 7b 52 45 53 4f |{SOURCES} ${RESO| 000000e0 55 52 43 45 53 7d 29 0a 0a 69 6e 73 74 61 6c 6c |URCES})..install| 000000f0 5f 6c 69 62 72 61 72 79 5f 61 6e 64 5f 73 79 6d |_library_and_sym| 00000100 62 6f 6c 73 20 28 46 61 63 74 6f 72 69 7a 61 74 |bols (Factorizat| 00000110 69 6f 6e 4d 61 63 68 69 6e 65 4e 61 74 69 76 65 |ionMachineNative| 00000120 29 |)| 00000121 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fmachinelearning%2Fpull%2F425%23issuecomment-400648969&data=02%7C01%7Csefilipi%40microsoft.com%7C79196a1e81a4414ef00d08d5dc26caaa%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636656981531960761&sdata=BOisnHhhUL%2FD1orJcljIydBEbKkmBn9uGYhVmnuG9o0%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASfn01xh3ih618zE5EdUWguXKnsBsaPJks5uA3XkgaJpZM4U49M6&data=02%7C01%7Csefilipi%40microsoft.com%7C79196a1e81a4414ef00d08d5dc26caaa%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636656981531960761&sdata=i6o3%2F4ic07kToxodabGLEIP5eWB6u4AhZr1vXgjNFoM%3D&reserved=0>.

[sfilipi]

Removed it, in PR: #430 Don’t have a good way to test it, because I can build on linux locally just fine… [cid:image001.png@01D40DED.D282E170] From: Senja Filipi Sent: Wednesday, June 27, 2018 7:55 AM To: 'dotnet/machinelearning' <reply@reply.github.com>; dotnet/machinelearning <machinelearning@noreply.github.com> Cc: Mention <mention@noreply.github.com> Subject: RE: [dotnet/machinelearning] removing extraneous character that broke the linux build, and with it the unnecessary cmake version requirement (#425) It builds fine locally.. Taking a look. From: Justin Ormont <notifications@github.com<mailto:notifications@github.com>> Sent: Wednesday, June 27, 2018 5:09 AM To: dotnet/machinelearning <machinelearning@noreply.github.com<mailto:machinelearning@noreply.github.com>> Cc: Senja Filipi <sefilipi@microsoft.com<mailto:sefilipi@microsoft.com>>; Mention <mention@noreply.github.com<mailto:mention@noreply.github.com>> Subject: Re: [dotnet/machinelearning] removing extraneous character that broke the linux build, and with it the unnecessary cmake version requirement (#425) I see a BOM on the file (0xEF, 0xBB, 0xBF). $ hexdump -C CMakeLists.txt 00000000 ef bb bf 70 72 6f 6a 65 63 74 20 28 46 61 63 74 |...project (Fact| 00000010 6f 72 69 7a 61 74 69 6f 6e 4d 61 63 68 69 6e 65 |orizationMachine| 00000020 4e 61 74 69 76 65 29 0a 0a 73 65 74 28 53 4f 55 |Native)..set(SOU| 00000030 52 43 45 53 0a 20 20 20 20 46 61 63 74 6f 72 69 |RCES. Factori| 00000040 7a 61 74 69 6f 6e 4d 61 63 68 69 6e 65 43 6f 72 |zationMachineCor| 00000050 65 2e 63 70 70 0a 29 0a 0a 69 66 28 57 49 4e 33 |e.cpp.)..if(WIN3| 00000060 32 29 0a 65 6c 73 65 28 29 0a 20 20 20 20 6c 69 |2).else(). li| 00000070 73 74 28 41 50 50 45 4e 44 20 53 4f 55 52 43 45 |st(APPEND SOURCE| 00000080 53 20 24 7b 56 45 52 53 49 4f 4e 5f 46 49 4c 45 |S ${VERSION_FILE| 00000090 5f 50 41 54 48 7d 29 0a 65 6e 64 69 66 28 29 0a |_PATH}).endif().| 000000a0 0a 61 64 64 5f 6c 69 62 72 61 72 79 28 46 61 63 |.add_library(Fac| 000000b0 74 6f 72 69 7a 61 74 69 6f 6e 4d 61 63 68 69 6e |torizationMachin| 000000c0 65 4e 61 74 69 76 65 20 53 48 41 52 45 44 20 24 |eNative SHARED $| 000000d0 7b 53 4f 55 52 43 45 53 7d 20 24 7b 52 45 53 4f |{SOURCES} ${RESO| 000000e0 55 52 43 45 53 7d 29 0a 0a 69 6e 73 74 61 6c 6c |URCES})..install| 000000f0 5f 6c 69 62 72 61 72 79 5f 61 6e 64 5f 73 79 6d |_library_and_sym| 00000100 62 6f 6c 73 20 28 46 61 63 74 6f 72 69 7a 61 74 |bols (Factorizat| 00000110 69 6f 6e 4d 61 63 68 69 6e 65 4e 61 74 69 76 65 |ionMachineNative| 00000120 29 |)| 00000121 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fmachinelearning%2Fpull%2F425%23issuecomment-400648969&data=02%7C01%7Csefilipi%40microsoft.com%7C79196a1e81a4414ef00d08d5dc26caaa%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636656981531960761&sdata=BOisnHhhUL%2FD1orJcljIydBEbKkmBn9uGYhVmnuG9o0%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASfn01xh3ih618zE5EdUWguXKnsBsaPJks5uA3XkgaJpZM4U49M6&data=02%7C01%7Csefilipi%40microsoft.com%7C79196a1e81a4414ef00d08d5dc26caaa%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636656981531960761&sdata=i6o3%2F4ic07kToxodabGLEIP5eWB6u4AhZr1vXgjNFoM%3D&reserved=0>.