Merge master into release/preview branch for v0.3 #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changes to RocketEngine to fix take top k logic. * Add namespace information to allow file to reference correct version of Formatting object.
* make class partial so I can add constuctor in separate file. add constructros for testing * formatting
…rics. Made the private const strings in two classes public. (#276)
* add missing subcomponents * right one * more cleanup
* first attempt * add comments * specify seed for random. make constructor internal.
* Fix for SupportedMetric.ByName() method. Include new unit test for function. * Fix for SupportedMetric.ByName() method. Include new unit test for function. * Fix for SupportedMetric.ByName() method. Include new unit test for function. * Removed unnecessary field filter, per review comment.
When training a FastTreeRanker using the `testFrequency` parameter, it is expected that NDCG is prented every testFrequency iterations. However, instead of NDCG, only empty strings are printed. The root cause was that the MaxDCG property of the dataset was never calculated, so the NDCG calculation is aborted, leaving an empty string as a result. This PR fixes the problem by computing the MaxDCG for the dataset when the Tests are defined (so that if the tests are not defined, the MaxDCG will never be calculated). Closes #242
Our release notes link is broken because the `Documentation` was renamed to `docs`. Fix this for the future to use a redirection link.
* Add release notes for ML.NET 0.2 * Adding release note about TextLoader changes and additional issue/PR references * Addressing comments: fixing typos, changing formatting, and adding references
…291) * Add label/grou/weight column name arguments to CV and train-test macros * Fix unit test. * Merge. * Update CSharp API. * Fix EntryPointCatalog test. * Address PR comments.
* update sample with new text loader API. * update with 0.2 stuff.
* Respect normalization in OVA. * some cleanup * fix copypaste issues
…training and inference (#248) * Export to ONNX and Maml cross-platform executable.
* Add Cluster evaluator * fix copypaste * address comments * formatting
The tests do not pass on systems with locale other than en-US. The error happens since the results are written to files and the contents of the files are compared to set of correct results produced under en-US locale. The fix is to imbue en-US culture to the test thread so that results will be output in format that is comparable with the test format. This patch fixes only tests, but do not guarantee calculation will be correct in production systems using a locale different than en-US. In particular, there can be problems in reading data and then conversing data from characters to numeric format. Fixes #74
…185) * Implement `ICanGetSummaryAsIDataView` on `PcaPredictor` class * Implement `ICanGetSummaryAsIRow` on `LinearPredictor` class
* Disable ols by temporarily removing the entry point. It may be added again once we figure out how to ship MKL as part of this project.
Add `Append` function to pipeline for more fluent API than that allowed by `Add`
fix namespace issue and refactoring
…or (#338) `CalibratorUtils.TrainCalibrator` and `TrainCalibratorIfNeeded` now creates `CalibratedPredictor` instead of `SchemaBindableCalibratedPredictor` whenever the predictor implements `IValueMapper`.
…osal. (#369) * Subclasses of `Stream` now have `Close` call `base.Close` to ensure disposal. * Add DeleteOnClose to File opening. * Remove explicit delete of file. * Remove explicit close of substream. * Since no longer deleting explicitly, no longer need `_overflowPath` member.
* Changed List to HashSet to ensure that there are no duplicates
* Update fast tree argument help text * Update wording * Update API to fix test * Update core manifest JSON to update help text
* Add a way to create a single tree ensemble model from multiple tree ensemble models. * Address PR comments, and fix bugs in serializing/deserializing RegressionTrees. * Address PR comments.
add pipelineitem for Ova
…ryPoints.md and GraphRunner.md (#295) * Adding EntryPoints.md and GraphRunner.md * addressing PR feedback * Updating the title of the GraphRunner.md file * adressing Tom's feedback * adressing feedback * code formatting for class names * Addressing Gal's comments * Adding an example of an entry point. Fixing casing on ML.NET * fixing link
Corrects an unintentional "typo" in FastTreeRanking.cs where there was mistakenly a USE_FASTTREENATIVE2 instead of USE_FASTTREENATIVE. This resulted in some obscure hidden ranking options (distance weighting, normalize query lambdas, and a few others) being unavailable. These are important for some applications.
* LightGBM and test. * add test baselines and nuget source for lightGBM binaries. * Add entrypoint for lightGBM. * add unsafe flag for release build. * update nuget version. * make lightgbm test single threaded. * install gcc on OS machines to resolve dependencies on openmp thatis needed by lightgbm native code. * PR comments. Leave BREW and GCC in bash script to verify macOS tests work. * remove brew and gcc from build script. * PR feedback. * disable test on macOS. * disable test on macOS. * PR feedback.
* Adding Factorization Machines
* ONNX API documentation.
Introduce Ensemble codebase
Create a shorter temp file name for model loading, as well as remove the potential for a race condition among multiple openings by using the creation of a lock file.
… unecessary cmake version requirement (#425)
…lues (#394) * Fix EvaluatorUtils to handle label column of type key without text key values.
|
More of a question of procedure, what is the role of this "preview" branch? I would have expected that we'd just take a branch off master at a given point, and call that the release, rather than try to merge into some other branch named "preview." Also I don't see that there was ever a 0.2 branch. Did someone forget to do that, or was that just not part of the plan? |
|
@TomFinley We did not forget. The plan was to move away from individual branches per release, as we will have many of those and the engineering system needed to support all of those branches would have become complex. Instead it was proposed that release/preview branch would be updated at each release with latest from master and tagged for each release. |
|
OK. Don't really get it but that's fine. Is the divergence of master and preview intentional? Edit: Whoops, I'm just wrong. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is cumulatively merging master into release branch in preparation for v0.3 release.