Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are excited to review your PR.
So we can do the best job, please check:
Fixes #nnnn
in your description to cause GitHub to automatically close the issue(s) when your PR is merged.The cause of #6416 is simple: calling
Cancel
on a disposedCancellationTokenSource
. TheCancellationTokenSource
might be disposed when the handler method get called.There're three ways to fix this issue
CancellationTokenSource
get disposed before cancelingCancellationTokenSource
and leave it to GCEventually I choose the third way because it's challenging to dispose object correctly in multi-thread situation. And checking if an object is diposed before calling seems to verbose.