Skip to content

fix #6416 #6612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2023
Merged

fix #6416 #6612

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddf28c7
remove handler
LittleLittleCloud Mar 29, 2023
a322df1
update
LittleLittleCloud Mar 29, 2023
c4a8655
checkout test file
LittleLittleCloud Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
141 changes: 70 additions & 71 deletions src/Microsoft.ML.AutoML/AutoMLExperiment/AutoMLExperiment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,94 +248,93 @@ public async Task<TrialResult> RunAsync(CancellationToken ct = default)
var parameter = tuner.Propose(trialSettings);
trialSettings.Parameter = parameter;

using (var trialCancellationTokenSource = new CancellationTokenSource())
var trialCancellationTokenSource = new CancellationTokenSource();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only actual change: removing using statement and leave disposing of trialCancellationTokenSource to GC

monitor?.ReportRunningTrial(trialSettings);
var stopTrialManager = new CancellationTokenStopTrainingManager(trialCancellationTokenSource.Token, null);
aggregateTrainingStopManager.AddTrainingStopManager(stopTrialManager);
void handler(object o, EventArgs e)
{
monitor?.ReportRunningTrial(trialSettings);

void handler(object o, EventArgs e)
{
trialCancellationTokenSource.Cancel();
}
try
trialCancellationTokenSource.Cancel();
}
try
{
using (var performanceMonitor = serviceProvider.GetService<IPerformanceMonitor>())
using (var runner = serviceProvider.GetRequiredService<ITrialRunner>())
{
using (var performanceMonitor = serviceProvider.GetService<IPerformanceMonitor>())
using (var runner = serviceProvider.GetRequiredService<ITrialRunner>())
aggregateTrainingStopManager.OnStopTraining += handler;
performanceMonitor.PerformanceMetricsUpdated += (o, metrics) =>
{
aggregateTrainingStopManager.OnStopTraining += handler;
performanceMonitor.PerformanceMetricsUpdated += (o, metrics) =>
{
performanceMonitor.OnPerformanceMetricsUpdatedHandler(trialSettings, metrics, trialCancellationTokenSource);
};

performanceMonitor.Start();
logger.Trace($"trial setting - {JsonSerializer.Serialize(trialSettings)}");
var trialResult = await runner.RunAsync(trialSettings, trialCancellationTokenSource.Token);

var peakCpu = performanceMonitor?.GetPeakCpuUsage();
var peakMemoryInMB = performanceMonitor?.GetPeakMemoryUsageInMegaByte();
trialResult.PeakCpu = peakCpu;
trialResult.PeakMemoryInMegaByte = peakMemoryInMB;
trialResult.TrialSettings.EndedAtUtc = DateTime.UtcNow;

performanceMonitor.Pause();
monitor?.ReportCompletedTrial(trialResult);
tuner.Update(trialResult);
trialResultManager?.AddOrUpdateTrialResult(trialResult);
aggregateTrainingStopManager.Update(trialResult);

var loss = trialResult.Loss;
if (loss < _bestLoss)
{
_bestTrialResult = trialResult;
_bestLoss = loss;
monitor?.ReportBestTrial(trialResult);
}
}
}
catch (Exception ex) when (aggregateTrainingStopManager.IsStopTrainingRequested() == false)
{
var exceptionMessage = $@"
Exception thrown during Trial {trialSettings.TrialId} with configuration {JsonSerializer.Serialize(trialSettings)}
performanceMonitor.OnPerformanceMetricsUpdatedHandler(trialSettings, metrics, trialCancellationTokenSource);
};

Exception Details: ex.Message
performanceMonitor.Start();
logger.Trace($"trial setting - {JsonSerializer.Serialize(trialSettings)}");
var trialResult = await runner.RunAsync(trialSettings, trialCancellationTokenSource.Token);

Abandoning Trial {trialSettings.TrialId} and continue training.
";
logger.Trace(exceptionMessage);
trialSettings.EndedAtUtc = DateTime.UtcNow;
monitor?.ReportFailTrial(trialSettings, ex);
var trialResult = new TrialResult
{
TrialSettings = trialSettings,
Loss = double.MaxValue,
};
var peakCpu = performanceMonitor?.GetPeakCpuUsage();
var peakMemoryInMB = performanceMonitor?.GetPeakMemoryUsageInMegaByte();
trialResult.PeakCpu = peakCpu;
trialResult.PeakMemoryInMegaByte = peakMemoryInMB;
trialResult.TrialSettings.EndedAtUtc = DateTime.UtcNow;

performanceMonitor.Pause();
monitor?.ReportCompletedTrial(trialResult);
tuner.Update(trialResult);
trialResultManager?.AddOrUpdateTrialResult(trialResult);
aggregateTrainingStopManager.Update(trialResult);

if (ex is not OperationCanceledException && _bestTrialResult == null)
var loss = trialResult.Loss;
if (loss < _bestLoss)
{
logger.Trace($"trial fatal error - {JsonSerializer.Serialize(trialSettings)}, stop training");

// TODO
// it's questionable on whether to abort the entire training process
// for a single fail trial. We should make it an option and only exit
// when error is fatal (like schema mismatch).
throw;
_bestTrialResult = trialResult;
_bestLoss = loss;
monitor?.ReportBestTrial(trialResult);
}
continue;
}
catch (Exception) when (aggregateTrainingStopManager.IsStopTrainingRequested())
}
catch (Exception ex) when (aggregateTrainingStopManager.IsStopTrainingRequested() == false)
{
var exceptionMessage = $@"
Exception thrown during Trial {trialSettings.TrialId} with configuration {JsonSerializer.Serialize(trialSettings)}

Exception Details: {ex.Message}

Abandoning Trial {trialSettings.TrialId} and continue training.
";
logger.Trace(exceptionMessage);
trialSettings.EndedAtUtc = DateTime.UtcNow;
monitor?.ReportFailTrial(trialSettings, ex);
var trialResult = new TrialResult
{
logger.Trace($"trial cancelled - {JsonSerializer.Serialize(trialSettings)}, stop training");
TrialSettings = trialSettings,
Loss = double.MaxValue,
};

break;
}
finally
tuner.Update(trialResult);
trialResultManager?.AddOrUpdateTrialResult(trialResult);
aggregateTrainingStopManager.Update(trialResult);

if (ex is not OperationCanceledException && _bestTrialResult == null)
{
aggregateTrainingStopManager.OnStopTraining -= handler;
logger.Trace($"trial fatal error - {JsonSerializer.Serialize(trialSettings)}, stop training");

// TODO
// it's questionable on whether to abort the entire training process
// for a single fail trial. We should make it an option and only exit
// when error is fatal (like schema mismatch).
throw;
}
continue;
}
catch (Exception) when (aggregateTrainingStopManager.IsStopTrainingRequested())
{
logger.Trace($"trial cancelled - {JsonSerializer.Serialize(trialSettings)}, stop training");

break;
}
finally
{
aggregateTrainingStopManager.OnStopTraining -= handler;
}
}

Expand Down