[tests] Fix NSDataTest.Https to use a site with a valid and complete certificate chain. Fixes #644. #3549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…certificate chain. Fixes dotnet#644. Fixes xamarin/maccore#644.
Contributor
|
Not sure it's needed - the certificate was renewed and now expires in 2020 |
Contributor
|
I'm not sure why it fails only on watchOS now (that the certificate was updated) and the logs are not helpful :( |
spouliot
approved these changes
Feb 21, 2018
Contributor
|
build |
Collaborator
|
Build success |
rolfbjarne
added a commit
to rolfbjarne/macios
that referenced
this pull request
Feb 21, 2018
…certificate chain. Fixes dotnet#644. (dotnet#3549) Fixes xamarin/maccore#644.
rolfbjarne
added a commit
to rolfbjarne/macios
that referenced
this pull request
Feb 21, 2018
…certificate chain. Fixes dotnet#644. (dotnet#3549) Fixes xamarin/maccore#644.
rolfbjarne
added a commit
that referenced
this pull request
Feb 21, 2018
…certificate chain. Fixes #644. (#3549) (#3556) Fixes xamarin/maccore#644.
spouliot
pushed a commit
that referenced
this pull request
Feb 21, 2018
…certificate chain. Fixes #644. (#3549) (#3559) Fixes https://github.com/xamarin/maccore/issues/644.
spouliot
pushed a commit
to spouliot/xamarin-macios
that referenced
this pull request
Mar 9, 2018
…certificate chain. Fixes dotnet#644. (dotnet#3549) Fixes https://github.com/xamarin/maccore/issues/644.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/xamarin/maccore/issues/644.