[modelio] Update for iOS 10 beta 2 #644
Conversation
|
Build failure |
|
@spouliot Introspection-mac work great locally. |
src/modelio.cs
Outdated
| // Added in iOS 10 SDK but it is supposed to be present in iOS 9. | ||
| [Mac (10,12)] | ||
| [Export ("colorSpace")] | ||
| string ColorSpace { get; set; } |
There was a problem hiding this comment.
that's a weird choice for a type, i.e. it's not a CGColorSpace. Can you double check the online documentation and the header file to see if there's any detail on its usage ?
I suspect it might be constants, and NSString might be better in such case to avoid conversions, but I don't recall seeing field-based colourspace constants...
There was a problem hiding this comment.
@spouliot there is 0 information about it, in neither the header nor the online doc ):
Do you want me to make it an NSString?
There was a problem hiding this comment.
yes, it's unlikely to be a user string and, sometimes, constants do pointer comparison so we better (without any doc) not take a chance
There was a problem hiding this comment.
Alright fixed.
|
LGTM but please check my comment about the ColorSpace property |
VincentDondain
force-pushed
the
modelio-b6
branch
from
db4ed3e to
e6689b1
Compare
|
Build success |
…certificate chain. Fixes dotnet#644. Fixes xamarin/maccore#644.
…certificate chain. Fixes dotnet#644. Fixes xamarin/maccore#644.
…certificate chain. Fixes #644. (#3549) Fixes xamarin/maccore#644.
…certificate chain. Fixes dotnet#644. (dotnet#3549) Fixes xamarin/maccore#644.
…certificate chain. Fixes dotnet#644. (dotnet#3549) Fixes xamarin/maccore#644.
…certificate chain. Fixes #644. (#3549) (#3556) Fixes xamarin/maccore#644.
…certificate chain. Fixes #644. (#3549) (#3559) Fixes https://github.com/xamarin/maccore/issues/644.
…certificate chain. Fixes dotnet#644. (dotnet#3549) Fixes https://github.com/xamarin/maccore/issues/644.
4 participants
Note: Beta 5 and Beta 6 changes canceled each others.