Synchronize back docs moved to https://docs.microsoft.com #3771

spouliot · 2018-03-16T16:38:40Z

No description provided.

spouliot · 2018-03-16T16:43:07Z

Work in progress (there's more docs to sync).
There's a lot of whitespace changes but it's either here or every time it's sync back...

@bradumbaugh please double check - it's largely your changes over our own

@chamons we need to fix 2100 for mmp :(

bradumbaugh · 2018-03-16T17:27:47Z

@spouliot Looks good. One change request: please put internal anchors such as <a name="MT0087"/> as the only element on a line, surrounded by newlines. Also, please put a space before the closing slash.

This:

<a name="MT0055" />

### MT0055: The Xcode path '*' does not exist.

Instead of:

### <a name="MT0055"/>MT0055: The Xcode path '*' does not exist.

chamons · 2018-03-16T17:28:32Z

Blah. At least 2100 is a simple error code. Patch in a second.

bradumbaugh · 2018-03-16T17:33:26Z

@spouliot Made an update above - I'd mistakenly left off a space after the # character.

chamons · 2018-03-16T17:43:02Z

@spouliot https://git.io/vxmHH should work for 2100

spouliot · 2018-03-16T18:01:10Z

@chamons please PR that on master but without mtouch-errors.md changes, since it will be overwritten when merging back (from 15.7)

chamons · 2018-03-16T18:02:03Z

On it.

spouliot · 2018-03-16T18:11:02Z

@bradumbaugh not sure I follow, there's no change for MT0055, i.e. https://github.com/xamarin/xamarin-macios/pull/3771/files#diff-656045af32acf6dda51d8e5dd079d5e2L238

or are you suggest a global change ?

The first commit is only a merge back from the version in xamarin-docs-pr which I assume was good enough, format wise :) We can discuss the future format since I don't want to keep the current one either inside #3570

IOW this PR is only so we don't overwrite your changes (in xamarin-docs-pr) when we're ready to release/publish 15.7 publicly

bradumbaugh · 2018-03-16T18:13:46Z

@spouliot Yes, I'm suggesting a global change for that doc. The current doc is going through a localization process that requires the anchors to be placed as I've described above, so that's a change that's in-process.

[edit] @spouliot If you'd like to wait until we have the change in the docs repository before making it here, that's fine - but we'll still need to circle back. Apologies for the confusion.

chamons · 2018-03-16T18:18:35Z

#3773 for the 2100 fixes

spouliot · 2018-03-16T18:37:39Z

@bradumbaugh whats the timeline for the localization change ?

VincentDondain · 2018-03-16T19:25:17Z

@spouliot about #3768 (comment), you didn't fix MM0132 here, only the mtouch error.

VincentDondain

LGTM except we should also fix MM0132 🙏

bradumbaugh · 2018-03-16T19:54:39Z

@spouliot I will make the necessary change and reply back today.

bradumbaugh · 2018-03-19T20:39:57Z

@spouliot The changes to anchors we discussed last week are in now in the master in the docs repo.

monojenkins · 2018-03-19T21:54:33Z

Build failure

monojenkins · 2018-04-10T03:42:32Z

Build success
Build comment file:

✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only)
✅ Generator Diff
✅ Test run succeeded

spouliot · 2018-04-10T15:35:52Z

@dalexsoto please review, in particular the binding documents (to make sure I did not miss anything you added).

@bradumbaugh one, hopefully, final review please :)

monojenkins · 2018-04-10T17:29:32Z

Build success
Build comment file:

✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only)
✅ Generator Diff
✅ Test run succeeded

monojenkins · 2018-04-10T21:51:34Z

Build failure
Build comment file:

✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only)
✅ Generator Diff
🔥 Test run failed 🔥

Test results

4 tests failed, 75 tests passed.

Failed tests

monotouch-test/iOS Unified 32-bits - simulator/Debug: TimedOut
introspection/iOS Unified 32-bits - simulator/Debug: TimedOut
monotouch-test/iOS Unified 32-bits - simulator/Debug (static registrar): TimedOut
monotouch-test/iOS Unified 32-bits - simulator/Release (all optimizations): TimedOut

spouliot · 2018-04-13T13:34:17Z

Failures are unrelated, something went wrong with 32bits sim/contact authorization -> https://github.com/xamarin/maccore/issues/737

dalexsoto

LGTM 👍

bradumbaugh

@spouliot Went through these changes, compared them to master, did a test publish to make sure things rendered correctly. A few changes requested - all pretty minor.

bradumbaugh · 2018-04-16T03:35:26Z

docs/website/binding_types_reference_guide.md

+### DesignatedDefaultCtorAttribute

 When this attribute is applied to the interface definition it will generate
 a `[DesignatedInitializer]` attribute on the default (generated) constructor


add a comma after "default (generated) constructor"

bradumbaugh · 2018-04-16T03:40:21Z

docs/website/binding_types_reference_guide.md

 ```

-When the `WrapAttribute` is used inside a `Category` you need to include `This` as
+When the `[WrapAttribute]` is used inside a `Category` you need to include `This` as


Should "Category" be "[Category]" here?

Should "This" be lowercase?

yes, it should be (in order of preference) [Category] or CategoryAttribute or [CategoryAttribute]
This is correct in this wrapped context

I re-worded the paragraph to explain why. Please review it again :)

Looks good.

bradumbaugh · 2018-04-16T03:43:53Z

docs/website/binding_types_reference_guide.md


-When the `WrapAttribute` is used inside a `Category` you need to include `This` as
+When the `[WrapAttribute]` is used inside a `Category` you need to include `This` as
 the first argument inside the `Wrap` signature, for example:


change to: "signature. For example:"

bradumbaugh · 2018-04-16T03:54:35Z

docs/website/binding_types_reference_guide.md

-## RequiresSuperAttribute
+### RequiresSuperAttribute

 This is a specialized subclass of the `[Advice]` attribute can be used


that can be used

bradumbaugh · 2018-04-16T03:55:02Z

docs/website/binding_types_reference_guide.md

+### RequiresSuperAttribute

 This is a specialized subclass of the `[Advice]` attribute can be used
 to hint the developer that overriding a method **requires** a call to 


to the developer

bradumbaugh · 2018-04-16T04:40:51Z

docs/website/xamarin-ios-analysis.md

-title: Xamarin.iOS Analysis Rules
-dateupdated: 2018-02-15
+title: "Xamarin.iOS analysis rules"
+ms.topic: article


change to:

ms.topic: troubleshooting

bradumbaugh · 2018-04-16T04:41:27Z

docs/website/xamarin-ios-analysis.md

- **Fix:** Double click on your iOS project, go to Build > iOS Build and for Release|iPhone, check the LLVM optimizing compiler option.
+## XIA0007: UseLLVMRule

+- **Problem:** For Release|iPhone configuration we recommend enabling the LLVM compiler which generates code that is faster to execute at the expense of build time.


**Release|iPhone** (bold)

It would be nicer but that text is extracted (by a tool) from Xamarin.iOS.Analysis.targets and it's shown in UI in places where markdown does not apply. IOW it cannot be applied to it's origin and will come back unformatted each time.

bradumbaugh · 2018-04-16T04:41:58Z

docs/website/xamarin-ios-analysis.md

+## XIA0007: UseLLVMRule

+- **Problem:** For Release|iPhone configuration we recommend enabling the LLVM compiler which generates code that is faster to execute at the expense of build time.
+- **Fix:** Double click on your iOS project, go to Build > iOS Build and for Release|iPhone, check the LLVM optimizing compiler option.


**Build > iOS Build** (bold)

**Release|iPhone**

bradumbaugh · 2018-04-16T04:47:14Z

docs/website/Makefile

 all: xamarin-analysis-doc
-	cp mtouch-errors.md $(WEBSITE_DOCS)/guides/ios/troubleshooting/mtouch-errors/index.md
+	cp mtouch-errors.md $(WEBSITE_DOCS)/docs/ios/troubleshooting/mtouch-errors.md
 	cp binding_objc_libs.md $(WEBSITE_DOCS)/guides/cross-platform/macios/binding/objective-c-libraries/index.md


This document lives at:

docs/cross-platform/macios/binding/objective-c-libraries.md

bradumbaugh · 2018-04-16T04:55:57Z

docs/website/Makefile

-	cp xamarin-ios-analysis.md $(WEBSITE_DOCS)/guides/ios/troubleshooting/xamarin-ios-analysis/index.md
+	cp binding_types_reference_guide.md $(WEBSITE_DOCS)/docs/cross-platform/macios/binding/binding-types-reference.md
+	cp xamarin-ios-analysis.md $(WEBSITE_DOCS)/ios/troubleshooting/xamarin-ios-analysis.md
 	cp optimizations.md $(WEBSITE_DOCS)/guides/cross-platform/macios/build-optimizations/index.md


I don't see this doc in the existing docs.microsoft.com TOC...

optimizations.md is new in 15.7. IIRC we discussed it with you a few week (months now?) back. c.c. @rolfbjarne

I created a PR for the documentation repo, which was postponed until the move to docs.microsoft.com: https://github.com/xamarin/documentation/pull/2845

Right - apologies for missing this. I'll look at adding this content today.

since it's new in 15.7 so it can wait for the release (since it won't be usable content until then)

Sounds good, I'll just get it ready.

PR here for build optimizations (waiting for 15.7 to merge): https://github.com/MicrosoftDocs/xamarin-docs-pr/pull/204

bradumbaugh · 2018-04-16T05:32:33Z

@spouliot One further question - @VincentDondain requested that we also publish https://github.com/xamarin/xamarin-macios/blob/master/docs/website/generator-errors.md. It will require similar changes to the anchors, etc. Should we include that as part of this PR or wait until it is published before doing so?

spouliot · 2018-04-16T19:23:06Z

@bradumbaugh for generator-errors.md we'll wait for 15.8 since we'll want IDE support (double click to error) and beside being too late for 15.7 we will do it "one page per error" from day one :)

bradumbaugh

Need to update the Makefile for the location of the build optimizations doc (hasn't been merged yet, but the Makefile is inconsistent with its future location)

bradumbaugh · 2018-04-16T21:05:24Z

docs/website/Makefile

-	cp xamarin-ios-analysis.md $(WEBSITE_DOCS)/guides/ios/troubleshooting/xamarin-ios-analysis/index.md
+	cp binding_types_reference_guide.md $(WEBSITE_DOCS)/docs/cross-platform/macios/binding/binding-types-reference.md
+	cp xamarin-ios-analysis.md $(WEBSITE_DOCS)/ios/troubleshooting/xamarin-ios-analysis.md
 	cp optimizations.md $(WEBSITE_DOCS)/guides/cross-platform/macios/build-optimizations/index.md


Staged the build optimizations content in a PR here: https://github.com/MicrosoftDocs/xamarin-docs-pr/pull/204.

Build optimizations will live here:

docs/cross-platform/macios/optimizations.md

bradumbaugh · 2018-04-16T21:05:58Z

docs/website/Makefile

+	-diff -u $(WEBSITE_DOCS)/docs/cross-platform/macios/binding/objective-c-libraries.md binding_objc_libs.md
+	-diff -u $(WEBSITE_DOCS)/docs/cross-platform/macios/binding/binding-types-reference.md binding_types_reference_guide.md
+	-diff -u $(WEBSITE_DOCS)/docs/ios/troubleshooting/xamarin-ios-analysis.md xamarin-ios-analysis.md
+	-diff -u $(WEBSITE_DOCS)/docs/cross-platform/macios/build-optimizations/index.md optimizations.md


Same as above; build optimizations doc will live here:

docs/cross-platform/macios/optimizations.md

monojenkins · 2018-04-16T21:45:43Z

Build failure
Build comment file:

✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only)
✅ Generator Diff

monojenkins · 2018-04-16T23:44:12Z

Build success
Build comment file:

✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only)
✅ Generator Diff
✅ Test run succeeded

Synchronize back docs moved to https://docs.microsoft.com

67d865f

spouliot added this to the d15-7 milestone Mar 16, 2018

spouliot added the do-not-merge Do not merge this pull request label Mar 16, 2018

spouliot mentioned this pull request Mar 16, 2018

[mtouch-mmp-errors] Fix missing " for 0132 #3768

Closed

spouliot added 2 commits March 16, 2018 13:07

Update bugzilla->github in descrptions (not error messages)

2c96f43

Sync xamarin-ios-analysis.md

60def70

Sync binding_types_reference_guide.md

fceacfb

VincentDondain approved these changes Mar 16, 2018

View reviewed changes

spouliot added the pr-change-not-shipping The PR only touch files that are not shipped to customers label Mar 23, 2018

spouliot added 2 commits April 9, 2018 21:18

Merge branch 'd15-7' into d15-7-docsync

7c3230e

Reaply previous bugzilla/github link changes

d7a6d09

rolfbjarne approved these changes Apr 10, 2018

View reviewed changes

Complete sync

b5ba562

spouliot removed the do-not-merge Do not merge this pull request label Apr 10, 2018

Add back some entries in mmp-errors.md

c14ad55

dalexsoto approved these changes Apr 13, 2018

View reviewed changes

bradumbaugh suggested changes Apr 16, 2018

View reviewed changes

Update with Brad's feedback

64dc102

bradumbaugh suggested changes Apr 16, 2018

View reviewed changes

Update final location for optimizations document

b11c357

bradumbaugh approved these changes Apr 16, 2018

View reviewed changes

spouliot merged commit c80edce into dotnet:d15-7 Apr 17, 2018

spouliot deleted the d15-7-docsync branch April 17, 2018 13:02

rolfbjarne mentioned this pull request Sep 17, 2018

Merge xcode10 into d15-9 #4820

Merged

Synchronize back docs moved to https://docs.microsoft.com #3771

Synchronize back docs moved to https://docs.microsoft.com #3771

Uh oh!

Conversation

spouliot commented Mar 16, 2018

Uh oh!

spouliot commented Mar 16, 2018

Uh oh!

bradumbaugh commented Mar 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chamons commented Mar 16, 2018

Uh oh!

bradumbaugh commented Mar 16, 2018

Uh oh!

chamons commented Mar 16, 2018

Uh oh!

spouliot commented Mar 16, 2018

Uh oh!

chamons commented Mar 16, 2018

Uh oh!

spouliot commented Mar 16, 2018

Uh oh!

bradumbaugh commented Mar 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chamons commented Mar 16, 2018

Uh oh!

spouliot commented Mar 16, 2018

Uh oh!

VincentDondain commented Mar 16, 2018

Uh oh!

VincentDondain left a comment

Choose a reason for hiding this comment

Uh oh!

bradumbaugh commented Mar 16, 2018

Uh oh!

bradumbaugh commented Mar 19, 2018

Uh oh!

monojenkins commented Mar 19, 2018

Uh oh!

monojenkins commented Apr 10, 2018

Build success Build comment file:

Uh oh!

spouliot commented Apr 10, 2018

Uh oh!

monojenkins commented Apr 10, 2018

Build success Build comment file:

Uh oh!

monojenkins commented Apr 10, 2018

Build failure Build comment file:

Test results

Failed tests

Uh oh!

spouliot commented Apr 13, 2018

Uh oh!

dalexsoto left a comment

Choose a reason for hiding this comment

Uh oh!

bradumbaugh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bradumbaugh commented Mar 16, 2018 •

edited

Loading

bradumbaugh commented Mar 16, 2018 •

edited

Loading

Build success
Build comment file:

Build success
Build comment file:

Build failure
Build comment file:

Build failure
Build comment file:

Build success
Build comment file: