Merge xcode10 into d15-9 #4820
Merged
Merge xcode10 into d15-9 #4820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Work around dotnet#4441 by commenting out binding until fixed
* [PDFKit] Update bindings to Xcode 10 Beta 1, 2 & 3 * Removes redundant availability attrib and fixes PDFKit library mapping case in xtro
…otnet#4443) Allso adds UIKit UIWebView deprecations
* [PassKit] Added support for Xcode 10 up to beta 3. * Minor style changes.
This used to be a calculated macro and got promoted to a field in macOS 10.13
…rt for DispatchData on bindings API
…ad of NetworkLibrary
…d closes connection
…ssed in the callback is null
This reverts commit 53fdc01. Unfortunately there is not enough info for the AOT compiler to handle MidiCIDeviceIdentification struct and this is causing mtouch tests to fail
…o do some of the block-callback heavy lifting
Bump for Xcode 10 beta 4
- Only on macOS - Only a subset of the uses are deprecated, see radar://42257568
* [Contacts] Update bindings to Xcode 10 Beta 4 * Fix typo
…r API with unit tests (dotnet#4784)
…otnet#4786) This means less (duplicated) manual code, which means less errors, which also means we're now getting some new members that previously weren't duplicated correctly. Fixes dotnet#4183.
* Avoid `ArgumentNullException` in default/empty `SecProtocolMetadata.PeerPublicKey` * Add two `SecProtocolMetadata.CreateSecret` API - disabled as the current tests (incomplete?) crash in unit tests * Add basic unit tests for `[Sec|NW]ProtocolMetadata` * Update xtro
Note that it included 173 new API so xtro files were updated to - include new API in .todo - add some backlog to .ignore files
VincentDondain
requested review from
dalexsoto,
emaf,
jstedfast,
kzu and
mandel-macaque
as code owners
spouliot
approved these changes
Sep 14, 2018
| IOS_PACKAGE_VERSION=12.2.$(PACKAGE_VERSION_REV).$(IOS_COMMIT_DISTANCE) | ||
| IOS_PACKAGE_VERSION_MAJOR=$(word 1, $(subst ., ,$(IOS_PACKAGE_VERSION))) | ||
| IOS_PACKAGE_VERSION_MINOR=$(word 2, $(subst ., ,$(IOS_PACKAGE_VERSION))) | ||
| IOS_PACKAGE_VERSION_REV=$(PACKAGE_VERSION_REV) |
emaf
approved these changes
Sep 14, 2018
Collaborator
|
Build failure Test results1 tests failed, 0 tests skipped, 218 tests passed.Failed tests
|
rolfbjarne
requested changes
Sep 17, 2018
| @@ -1,21 +1,23 @@ | |||
| TOP=../../.. | |||
| WEBSITE_DOCS ?= $(TOP)/documentation | |||
| WEBSITE_DOCS ?= $(TOP)/xamarin-docs-pr | |||
Member
Contributor
There was a problem hiding this comment.
Since we only merge those from a release branch I think it was fine (for 15.7) but it should have been merged (last Xcode) back into master. Not a big deal since we need to update that process soon anyway.
|
|
||
| If this is not the case, please file a bug at [https://bugzilla.xamarin.com](https://bugzilla.xamarin.com/enter_bug.cgi?product=Xamarin.Mac) with a test case. | ||
|
|
||
| ### <a name="MM4175"/>MM4175: The parameter '{parameter}' in the method '{method}' has an invalid BlockProxy attribute (the type passed to the attribute does not have a 'Create' method). |
Member
There was a problem hiding this comment.
The text for MM4175 shouldn't be deleted.
|
|
||
| This warning can most likely be ignored; in case of any problems file a bug (https://bugzilla.xamarin.com](https://bugzilla.xamarin.com/enter_bug.cgi?product=iOS)) and it will be investigated. | ||
|
|
||
| ### <a name="MT0129"/>MT0129: Debugging symbol file for '*' does not match the assembly and is ignored. |
Member
There was a problem hiding this comment.
The text for MT0129-MT0134 shouldn't be gone.
rolfbjarne
approved these changes
Sep 17, 2018
jstedfast
approved these changes
Sep 17, 2018
emaf
approved these changes
Sep 17, 2018
Collaborator
|
Build failure Test results1 tests failed, 0 tests skipped, 218 tests passed.Failed tests
|
Contributor
Author
|
Test failure is a known issue: https://github.com/xamarin/maccore/issues/1026 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maccorethat has a bump ofmaciostoolthat's usingXamarin.MacDev's d15-9 branch.Xamarin.MacDevinxamarin-macioswas already usingd15-9which is equivalent toxcode10andmachos-binaries'sd15-9branch is equivalent toxcode10too.Note:
tools/common/Frameworks.csrequired a bit more work than other files, it's a fusion of 9f90691 and 215ab7f.