Bump for Xcode 10 beta 4 #4459

dalexsoto · 2018-07-18T01:47:36Z

A note about merging this PR:

Let's NOT squash commits and do a merge commit instead so it is easier to revert the macOS tests and bumps of min versions to 10.9 in case we do not want to follow this path.

monojenkins · 2018-07-18T03:02:52Z

Build failure
❌ Build was aborted

🔥 Build failed 🔥

VincentDondain · 2018-07-18T12:40:40Z

/Applications/Xcode10-beta4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/simd/math.h:1403:10: fatal error:
      'cmath' file not found
#include <cmath>
         ^~~~~~~

monojenkins · 2018-07-18T13:32:01Z

Build failure
❌ Build was aborted

🔥 Build failed 🔥

monojenkins · 2018-07-18T15:18:28Z

Build failure
❌ Build was aborted

🔥 Build failed 🔥

chamons · 2018-07-18T15:48:17Z

That 👍 is obviously conditional on builds/test passing, but the idea looks right.

monojenkins · 2018-07-18T16:46:40Z

Build failure
❌ Build was aborted

🔥 Build failed 🔥

…mpilation issues

monojenkins · 2018-07-18T20:16:03Z

Build failure
❌ Build was aborted

monojenkins · 2018-07-19T01:13:58Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (🔥 breaking changes 🔥)
✅ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

8 tests failed, 148 tests passed.

Failed tests

introspection/Mac Unified: Failed (Test run failed.)
System/iOS Unified 32-bits - simulator/Debug: Failed
monotouch-test/iOS Unified 64-bits - simulator/Debug: TimedOut
introspection/iOS Unified 64-bits - simulator/Debug: TimedOut
monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): TimedOut
monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): TimedOut
introspection/tvOS - simulator/Debug: TimedOut
MTouch tests/NUnit: Failed (Execution failed with exit code 8)

dalexsoto · 2018-07-19T02:20:08Z

We are getting there

monojenkins · 2018-07-19T04:45:17Z

Build failure
❌ Build was aborted

dalexsoto · 2018-07-19T04:49:49Z

So I've verified locally that intro and xtro pass on both iOS 12 B4 and macOS 10.13/10.14 B4 also monotouch-tests run fine for me.

About MTouch it is still running locally so I will report back, that said those failures seemed to be legal and we might need to file an issue in order to merge this.

A note about merging this PR: Let's NOT squash commits and do a merge commit instead so it is easier to revert the macOS tests and bumps of min versions to 10.9 in case we do not want to follow this path.

monojenkins · 2018-07-19T09:39:13Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (🔥 breaking changes 🔥)
✅ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

6 tests failed, 150 tests passed.

Failed tests

monotouch-test/iOS Unified 64-bits - simulator/Debug: TimedOut
introspection/iOS Unified 64-bits - simulator/Debug: TimedOut
monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): TimedOut
monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): TimedOut
introspection/tvOS - simulator/Debug: TimedOut
MTouch tests/NUnit: Failed (Execution failed with exit code 8)

VincentDondain · 2018-07-19T13:54:27Z

I think the timed out tests would pass if we re run but not the mtouch test. Not sure what's wrong with it.

VincentDondain · 2018-07-19T15:00:02Z

Full verbose build log of the mtouch AOT failure: https://gist.github.com/VincentDondain/faf612e93c8568aec1024aa2f2ad3a76

@dalexsoto found out it was related to 53fdc01#diff-ff9e35b87c66245efc6f4798e6aa6cd9R12. The mtouch tests didn't run for this PR.

This reverts commit 53fdc01. Unfortunately there is not enough info for the AOT compiler to handle MidiCIDeviceIdentification struct and this is causing mtouch tests to fail

monojenkins · 2018-07-19T15:06:07Z

Build failure
❌ Build was aborted

monojenkins · 2018-07-19T19:14:44Z

Build success
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (🔥 breaking changes 🔥)
✅ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 155 tests passed.

Failed tests

Generator tests/NUnit: BuildFailure

dalexsoto · 2018-07-19T20:46:11Z

build

monojenkins · 2018-07-20T02:56:36Z

Build success
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (🔥 breaking changes 🔥)
✅ Generator Diff (please review changes)
✅ Test run succeeded

dalexsoto · 2018-07-20T03:07:17Z

Breaking changes are expected from API changes from the previous beta

dalexsoto added this to the xcode10 milestone Jul 18, 2018

dalexsoto requested review from VincentDondain, rolfbjarne and spouliot as code owners July 18, 2018 01:47

dalexsoto mentioned this pull request Jul 18, 2018

Fix introspection test results on new macOS beta #4457

Closed

dalexsoto requested a review from chamons July 18, 2018 01:49

chamons approved these changes Jul 18, 2018

View reviewed changes

dalexsoto and others added 4 commits July 18, 2018 15:10

Bump for Xcode 10 beta 4

c197102

Temporarily bump the MIN_OSX_SDK_VERSION to 10.9 to avoid SceneKit co…

63a4f19

…mpilation issues

Update min macOS version in Versions-mac.plist

0fdcd45

More 10.7 -> 10.9 bumps

24a4360

dalexsoto force-pushed the Xcode10-Beta4 branch from 5e74fb5 to dd5594e Compare July 18, 2018 20:10

dalexsoto added 2 commits July 18, 2018 22:45

Bump tests minimum version from 10.7 to 10.9

acc5890

[TVMLKit] Update bindings to Xcode 10 Beta 4

95705d5

dalexsoto force-pushed the Xcode10-Beta4 branch from dd5594e to 95705d5 Compare July 19, 2018 03:46

[tests] Fix introspection tests in macOS 10.13

035fed8

[xharness] Fix simulator hangs in our tests

313cb7d

Revert "[CoreMidi] Xcode 10 beta 3 update. (dotnet#4453)"

9bf520f

This reverts commit 53fdc01. Unfortunately there is not enough info for the AOT compiler to handle MidiCIDeviceIdentification struct and this is causing mtouch tests to fail

VincentDondain approved these changes Jul 19, 2018

View reviewed changes

dalexsoto merged commit 2d1a314 into dotnet:xcode10 Jul 20, 2018

dalexsoto deleted the Xcode10-Beta4 branch July 20, 2018 03:06

Bump for Xcode 10 beta 4 #4459

Bump for Xcode 10 beta 4 #4459

Uh oh!

Conversation

dalexsoto commented Jul 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

monojenkins commented Jul 18, 2018

Uh oh!

VincentDondain commented Jul 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

monojenkins commented Jul 18, 2018

Uh oh!

monojenkins commented Jul 18, 2018

Uh oh!

chamons commented Jul 18, 2018

Uh oh!

monojenkins commented Jul 18, 2018

Uh oh!

monojenkins commented Jul 18, 2018

Uh oh!

monojenkins commented Jul 19, 2018

Test results

Failed tests

Uh oh!

dalexsoto commented Jul 19, 2018

Uh oh!

monojenkins commented Jul 19, 2018

Uh oh!

dalexsoto commented Jul 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

monojenkins commented Jul 19, 2018

Test results

Failed tests

Uh oh!

VincentDondain commented Jul 19, 2018

Uh oh!

VincentDondain commented Jul 19, 2018

Uh oh!

monojenkins commented Jul 19, 2018

Uh oh!

monojenkins commented Jul 19, 2018

Test results

Failed tests

Uh oh!

dalexsoto commented Jul 19, 2018

Uh oh!

monojenkins commented Jul 20, 2018

Uh oh!

dalexsoto commented Jul 20, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dalexsoto commented Jul 18, 2018 •

edited

Loading

VincentDondain commented Jul 18, 2018 •

edited

Loading

dalexsoto commented Jul 19, 2018 •

edited

Loading