Skip to content

[msbuild] Fix AOT options from IDE #3914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chamons merged 2 commits into from
Apr 10, 2018
Merged

[msbuild] Fix AOT options from IDE #3914

chamons merged 2 commits into from
Apr 10, 2018

Conversation

@chamons
Copy link
Contributor

@chamons chamons commented Apr 10, 2018

  • AOT options set from the IDE were not honored in msbuild and did nothing

chamons added 2 commits April 10, 2018 10:51
@chamons
Add failing test for tag issue
ee79987
@chamons
[msbuild] Update msbuild to use correct XM AOT variables
f2f06c5 
- The IDE saves out AOTMode and HybridAOT but msbuild was older names
@chamons chamons requested a review from jstedfast April 10, 2018 16:06
@chamons chamons added the run-mmp-tests Run the mmp tests label Apr 10, 2018
@chamons
Copy link
Contributor Author

chamons commented Apr 10, 2018

build

@chamons
Copy link
Contributor Author

chamons commented Apr 10, 2018

I believe it is safe to remove:

-		public string AotScope { get; set; }
-		public bool HybridAotOption { get; set; }

and use the new names as they were never written out by the IDE fwict.

spouliot
spouliot approved these changes Apr 10, 2018
View reviewed changes
Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the test

@monojenkins
Copy link
Collaborator

monojenkins commented Apr 10, 2018

Build failure
Build comment file:

✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only)
✅ Generator Diff
🔥 Test run failed 🔥

Test results

1 tests failed, 0 tests skipped, 81 tests passed.

Failed tests

  • monotouch-test/watchOS - simulator/Debug: Failed

@chamons chamons mentioned this pull request Apr 10, 2018
Merged
@chamons
Copy link
Contributor Author

chamons commented Apr 10, 2018

Failure is unrelated - https://github.com/xamarin/maccore/issues/701

@chamons chamons merged commit 659a74c into dotnet:master Apr 10, 2018
@chamons chamons deleted the xm_aot_tag_fix branch April 10, 2018 18:42
@monojenkins
Copy link
Collaborator

monojenkins commented Apr 10, 2018

Build failure
Build comment file:

✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only)
✅ Generator Diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emaf emaf Awaiting requested review from emaf

@kzu kzu Awaiting requested review from kzu

@rolfbjarne rolfbjarne Awaiting requested review from rolfbjarne

@VincentDondain VincentDondain Awaiting requested review from VincentDondain

2 more reviewers

@spouliot spouliot spouliot approved these changes

@jstedfast jstedfast jstedfast approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

run-mmp-tests Run the mmp tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chamons @monojenkins @spouliot @jstedfast