Skip to content

[d15-7][msbuild] Fix AOT options from IDE #3916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spouliot merged 2 commits into from
Apr 18, 2018
Merged

[d15-7][msbuild] Fix AOT options from IDE #3916

spouliot merged 2 commits into from
Apr 18, 2018

Conversation

@chamons
Copy link
Contributor

@chamons chamons commented Apr 10, 2018 •
edited
Loading

chamons added 2 commits April 10, 2018 13:34
@chamons
Add failing test for tag issue
7b46eee
@chamons
[msbuild] Update msbuild to use correct XM AOT variables
987bc1a 
- The IDE saves out AOTMode and HybridAOT but msbuild was older names
@spouliot spouliot added the requires-approval-before-merge The pull request requires special approval before it can be merged label Apr 10, 2018
@spouliot spouliot added this to the d15-7 milestone Apr 10, 2018
@spouliot
Copy link
Contributor

spouliot commented Apr 10, 2018

For posterity (since it was reported as a question) and solved before being filed
https://xamarinhq.slack.com/archives/C03CCJHCF/p1523359520000414

@monojenkins
Copy link
Collaborator

monojenkins commented Apr 10, 2018

Build success
Build comment file:

✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only)
✅ Generator Diff
✅ Test run succeeded

@chamons
Copy link
Contributor Author

chamons commented Apr 11, 2018

I filed #3920 for this, as I fixed it in master before the issue was filed.

@spouliot
Copy link
Contributor

spouliot commented Apr 18, 2018

Chatted with @AdrianMurphy. Merging for QA verification before P5

@spouliot spouliot merged commit 3c5a498 into dotnet:d15-7 Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@emaf emaf emaf approved these changes

@kzu kzu Awaiting requested review from kzu

+2 more reviewers

@jstedfast jstedfast jstedfast approved these changes

@VincentDondain VincentDondain VincentDondain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

requires-approval-before-merge The pull request requires special approval before it can be merged

Projects

None yet

Milestone

d15-7

Development

Successfully merging this pull request may close these issues.

8 participants

@chamons @spouliot @monojenkins @dalexsoto @rolfbjarne @jstedfast @emaf @VincentDondain