Bump for Xcode 11.1 GM #7090
Bump for Xcode 11.1 GM #7090
Conversation
) - Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/959179 - Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/956758 * Actually 12.3 & 12.4 are still on the 12.2 SDK * Turns out our version plist check is assuming max version supported = max sdk version
VincentDondain
requested review from
rolfbjarne and
spouliot
as code owners
Make.config
Outdated
| XCODE_DEVELOPER_ROOT=/Applications/Xcode11.app/Contents/Developer | ||
| XCODE_VERSION=11.1 | ||
| XCODE_URL=http://xamarin-storage/bot-provisioning/xcodes/Xcode_11.1_GM_Seed.xip | ||
| XCODE_DEVELOPER_ROOT=/Applications/Xcode11.1-GM.app/Contents/Developer |
There was a problem hiding this comment.
is that the location on the bots ?
it does not match https://xamarinhq.slack.com/archives/C99ER4A1M/p1569347681015300
There was a problem hiding this comment.
Yeah I think we went with this https://xamarinhq.slack.com/archives/C03CEMRFL/p1569348227198300
Xcode111-GM.app
spouliot
left a comment
spouliot
left a comment
There was a problem hiding this comment.
You should use the bump PR to change the reference for apidiff to point to the current stable :)
|
Build failure |
|
Build failure Test results1 tests failed, 86 tests passed.Failed tests
|
|
@VincentDondain CoreBluetooth is making the tests on Mac OS X fail, we did have some changes in there, we need to update the tests. |
``` ObjCRuntime.RuntimeException: Failed to marshal the Objective-C object 0x7ff62ff227f0 (type: MonoTouchFixtures_CoreBluetooth_CBCentralManagerTest_ManagerDelegate). Could not find an existing managed instance for this object, nor was it possible to create a new managed instance (because the type 'MonoTouchFixtures.CoreBluetooth.CBCentralManagerTest+ManagerDelegate' does not have a constructor that takes one IntPtr argument). ``` Therefore, add the `IntPtr` `.ctor` (Note: I cannot reproduce locally so I'm eyeballing this)
|
So I'm not quite sure how we end up in this situation on macOS: I was also thinking there could be a problem with the test I'll take thoughts on this (: |
| public ManagerDelegate (IntPtr handle) : base (handle) | ||
| { | ||
| } | ||
|
|
There was a problem hiding this comment.
That won't set the managed state (Event) back to a valid (non-null) value. It will likely work, just like rebuilding would have - i.e. your code change being irrelevant to the test success/failure.
My guess is that the 5sec timeout occurred on the bot and, while TearDown happened the callback occurred, throwing before the timeout assertion could occur.
You can try to duplicate this locally with a much shorter timeout.
There was a problem hiding this comment.
Still can't repro...
I tried playing with mgrDelegate.Event.WaitOne and the test's timeout [Timeout] and couldn't get the TearDown to happen before the Asserts...
I'm gonna ignore the test, file a bug and merge that PR so we can get going.
There was a problem hiding this comment.
Mmh actually it might be ScanForPeripherals failing... not RetrievePeripherals
|
Build failure 🔥 Build failed 🔥 |
|
build |
|
Build success |
- Fixes dotnet#7045 - Fixes Xcode path and point API diff to HEAD of d16-3 - Ignore ScanForPeripherals & RetrievePeripherals tests for now (dotnet#7108)
6 participants
No description provided.