Skip to content

Commit bc88893

Browse files
jonathanantoinegithub-actions[bot]mattleibowTamilarasan-ParanthamanNafeelaNazhir
committed
Perf : ButtonContentTypeConverter now using InvariantCulture to parse… (#25393)
* [create-pull-request] automated change (#29793) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Convert HybridWebView.js to TypeScript and embed (#27183) * Fix up relevant CA1416 warnings - Set 3 (#26751) * [Testing] Feature Matrix UITest Cases for CollectionView Dynamic changes (#29424) * Added FeatureTests for CollectionView * changes updated * changes updated * [create-pull-request] automated change (#29505) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * CA1416 warning fix * Added snapshots * Reverting files changes * Removed the old approach * Revert unwanted changes * Reverted unwanted changes * Reverted unwanted changes * Revert unwanted changes --------- Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix up relevant CA1416 warnings - Set 1 (#26696) * Changed Syncfusion toolkit version from 1.0.4 to 1.0.5 (#29659) * [ci] Update dependencies from 9.0.4 to 9.0.5 (#29667) * [ci] Update dependencies from 9.0.4 to 9.0.5 * Update the net8 version * Add missing version MicrosoftJSInteropPackageVersion * Page.OnBackButtonPressed remove outdated API documentation (#29543) * Fixed KeepLastItemInView Does Not Scroll to Last Item When Adding Items at Top (#29632) * Fixed KeepLastItem not scrolled to last item * Updated Fix * Updated test sample * Added comment line * Updated test sample for iOS and mac * Added Snapshots for android and WinUI * Added UI tests. * Test sample changes. * script changes * script changes * Added snapshots * Resaved Mac images and the gradient image size issue has been fixed * CA1416 warning changes * Reverted unwanted changes --------- Co-authored-by: Paul Anderson <42271912+PaulAndersonS@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com> * [iOS/Mac]Fix StrokeDashArray Property not Rendering (#29670) * fix added * Test added * snap added * [Android/ iOS] Fix Flyout icon is displayed when flyout is disabled (#29637) * fix added * modified the fix * test case added * test case added * summary added * Script name changed * [Android & iOS] Fix for SearchHandler Character Spacing Property (#29497) * [Android & iOS] Fix for character spacing in searchHandler * Updated test sample concerns * Update on naming * Update on formatting * Allowing updating character spacing to zero * Updated Andorid, iOS, Mac images * [create-pull-request] automated change (#29724) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Windows] Fix for SearchHandler Visibility Not Updating During In-Section Navigation (#29441) * fix-17521-Updates the SearchHandler when navigating to another page within same ShellSection. * fix-17521-Added testcase and added snapshot for Android and iOS. * fix-17521-Renamed Shell_Navigated to OnShellNavigated. * fix-17521-Modified the Location string value from "Ethopia" to "Ethiopia". * fix-17521-Snapshot updated. * fix-17521-Updated Windows and Mac Snapshot. * [Windows] - Fix view position shift when shadows are added or removed at runtime (#29681) * Fix-view-position-shift-when-toggling-shadows * Added-Pending-SnapShots * Resaved-image * [Testing] Feature Matrix UITest Cases for Shadows (#27701) * Added sample to Matrix UITest Cases for Shadow * Renamed sample page * Renamed sample page * More tests * More tests * More tests * More tests * Added shadow tests * Updated sample * Added Windows snapshots * Updated tests * Added link to issue * More changes * Updated sample reset logic * Updated sample * More changes * More changes * More changes * Updated sample * Added snapshots * Hide cursor * More changes * More snapshots * Updated tests * Updated iOS snapshots * Updated iOS snapshots * Updated snapshots * Updated snapshots * Updated tests * [housekeeping] Automated PR to fix formatting errors on uitest-shadow-feature * Updated tests * Fix build errors * More changes * More changes * More changes * More changes --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [iOS] Fixed Shell.SearchHandler ClearPlaceholderIcon Color Issue (#28601) * SearchHandler ClearPlaceholderIcon color fix * Added Mac snapshot * Updated SearchBar Icon changes * Test script changes. * Revert unwanted changes * Updated custom icon changes * Fix -[iOS] - CarouselView Throws ArgumentOutOfRangeException Immediately on Application Launch in CV2 (#29316) * Update ItemsSourceFactory2.cs * Update CarouselViewPositionVisibility.xaml * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView (#29660) * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView * Have added test case * Updated AutomationId for better clarity and readability * Have modified the context of the description label * Have committed the snapshots * [Testing] Feature Matrix UITest Cases for Label (#29690) * Added Label Feature tests * changes updated * changes updated * changes updated * Added Screenshots * Added Snapshots for iOS * Corrected Mistakes * Added snapshots * Added images * Renamed file --------- Co-authored-by: Rui Marinho <me@ruimarinho.net> * updated base images for candidate PR failures (#29766) * [Android] Fix: Modal Animation Repeats When Returning from Background 3 (#29702) * fix * dispose listner once not needed * Revert "dispose listner once not needed" * call invalidate * add device test to check for leaks * null check and remove strong references in callback * Throw if rootview is null before adding animation * fix spelling mistake * [Testing] Include a tolerance parameter in the Verifyscreenshot method (#29776) * Added tolerance parameter to the VerifyScreenshot method * More changes * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * [Testing] Update Appium to v8 (#29774) * Update Appium to the latest version * Removed deprecated logic * Update comment * [create-pull-request] automated change (#29831) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Perf : ButtonContentTypeConverter now using InvariantCulture to parse double --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Tamilarasan Paranthaman <93904422+Tamilarasan-Paranthaman@users.noreply.github.com> Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: Paul Anderson <42271912+PaulAndersonS@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com> Co-authored-by: devanathan-vaithiyanathan <114395405+devanathan-vaithiyanathan@users.noreply.github.com> Co-authored-by: Subhiksha Chandrasekaran <subhiksha.c@syncfusion.com> Co-authored-by: BagavathiPerumal <93652794+BagavathiPerumal@users.noreply.github.com> Co-authored-by: prakashKannanSf3972 <127308739+prakashKannanSf3972@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: SuthiYuvaraj <92777079+SuthiYuvaraj@users.noreply.github.com> Co-authored-by: SyedAbdulAzeemSF4852 <syedabdulazeem.a@syncfusion.com> Co-authored-by: Anandhan Rajagopal <97146406+anandhan-rajagopal@users.noreply.github.com> Co-authored-by: Bhavanesh N <bhavanesh001@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
1 parent 69b1d00 commit bc88893

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Controls/src/Core/Button/Button.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,7 @@ public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo c
598598
int spacingIndex = spacingFirst ? 0 : (parts.Length == 2 ? 1 : -1);
599599

600600
if (spacingIndex > -1)
601-
spacing = double.Parse(parts[spacingIndex]);
601+
spacing = double.Parse(parts[spacingIndex], CultureInfo.InvariantCulture);
602602

603603
if (positionIndex > -1)
604604
position = (ButtonContentLayout.ImagePosition)Enum.Parse(typeof(ButtonContentLayout.ImagePosition), parts[positionIndex], true);

0 commit comments

Comments
 (0)