[Windows] - Fix view position shift when shadows are added or removed at runtime #29681

prakashKannanSf3972 · 2025-05-27T06:18:22Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Root Cause

In the RemoveContainer method, the code incorrectly used PlatformView.Parent to reference the parent of the ContainerView. However, PlatformView.Parent actually points to the ContainerView itself rather than the panel containing it. This caused the following issues:

oldIndex returned -1 when searching for the ContainerView.
Fallback logic executed, which failed to properly clean up.
A disconnected ContainerView remained, disrupting layout calculations.

As a result, coordinate transformations and layout measurements became inconsistent, leading to misalignment.

Description of Change

The RemoveContainer method was updated to correctly reference the parent of the ContainerView using ContainerView.Parent instead of PlatformView.Parent. This change ensures that:

The ContainerView is accurately located in its parent children collection.
The ContainerView is completely removed from the visual tree.
The PlatformView is properly reinserted at its original index.
Layout calculations proceed with a consistent and clean.

Regressed PR

[Windows] Optimize LayoutHandler.Windows.cs (take 3) #26722

Issues Fixed

Fixes #27732

Tested the behaviour in the following platforms

Android
Windows
iOS
Mac

Output

Before	After
BeforeFix.mp4	AfterFix.mp4

dotnet-policy-service · 2025-05-27T06:20:50Z

Hey there @@prakashKannanSf3972! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

jsuarezruiz · 2025-05-27T07:50:18Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-27T07:50:30Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull Request Overview

This PR fixes the runtime shift in view positioning on Windows by correctly locating and removing the ContainerView from its parent, and adds automated UI tests and a host app sample to verify the fix.

Correct RemoveContainer to use ContainerView.Parent instead of PlatformView.Parent.
Add a UI test (Issue27732) in TestCases.Shared.Tests that toggles shadows and verifies no positional shift.
Include a host app sample (Issue27732) in TestCases.HostApp with controls and automation IDs to drive the test.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File	Description
src/Core/src/Handlers/View/ViewHandlerOfT.Windows.cs	Fix `RemoveContainer` parent reference lookup
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue27732.cs	Add NUnit UI test for toggling shadows and screenshot check
src/Controls/tests/TestCases.HostApp/Issues/Issue27732.cs	Add host app sample page with controls and automation IDs

jsuarezruiz · 2025-05-28T06:02:07Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-28T06:02:22Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz · 2025-05-29T09:27:28Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-29T09:27:40Z

Azure Pipelines successfully started running 1 pipeline(s).

… at runtime (#29681) * Fix-view-position-shift-when-toggling-shadows * Added-Pending-SnapShots * Resaved-image

#25393) * [create-pull-request] automated change (#29793) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Convert HybridWebView.js to TypeScript and embed (#27183) * Fix up relevant CA1416 warnings - Set 3 (#26751) * [Testing] Feature Matrix UITest Cases for CollectionView Dynamic changes (#29424) * Added FeatureTests for CollectionView * changes updated * changes updated * [create-pull-request] automated change (#29505) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * CA1416 warning fix * Added snapshots * Reverting files changes * Removed the old approach * Revert unwanted changes * Reverted unwanted changes * Reverted unwanted changes * Revert unwanted changes --------- Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix up relevant CA1416 warnings - Set 1 (#26696) * Changed Syncfusion toolkit version from 1.0.4 to 1.0.5 (#29659) * [ci] Update dependencies from 9.0.4 to 9.0.5 (#29667) * [ci] Update dependencies from 9.0.4 to 9.0.5 * Update the net8 version * Add missing version MicrosoftJSInteropPackageVersion * Page.OnBackButtonPressed remove outdated API documentation (#29543) * Fixed KeepLastItemInView Does Not Scroll to Last Item When Adding Items at Top (#29632) * Fixed KeepLastItem not scrolled to last item * Updated Fix * Updated test sample * Added comment line * Updated test sample for iOS and mac * Added Snapshots for android and WinUI * Added UI tests. * Test sample changes. * script changes * script changes * Added snapshots * Resaved Mac images and the gradient image size issue has been fixed * CA1416 warning changes * Reverted unwanted changes --------- Co-authored-by: Paul Anderson <42271912+PaulAndersonS@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com> * [iOS/Mac]Fix StrokeDashArray Property not Rendering (#29670) * fix added * Test added * snap added * [Android/ iOS] Fix Flyout icon is displayed when flyout is disabled (#29637) * fix added * modified the fix * test case added * test case added * summary added * Script name changed * [Android & iOS] Fix for SearchHandler Character Spacing Property (#29497) * [Android & iOS] Fix for character spacing in searchHandler * Updated test sample concerns * Update on naming * Update on formatting * Allowing updating character spacing to zero * Updated Andorid, iOS, Mac images * [create-pull-request] automated change (#29724) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Windows] Fix for SearchHandler Visibility Not Updating During In-Section Navigation (#29441) * fix-17521-Updates the SearchHandler when navigating to another page within same ShellSection. * fix-17521-Added testcase and added snapshot for Android and iOS. * fix-17521-Renamed Shell_Navigated to OnShellNavigated. * fix-17521-Modified the Location string value from "Ethopia" to "Ethiopia". * fix-17521-Snapshot updated. * fix-17521-Updated Windows and Mac Snapshot. * [Windows] - Fix view position shift when shadows are added or removed at runtime (#29681) * Fix-view-position-shift-when-toggling-shadows * Added-Pending-SnapShots * Resaved-image * [Testing] Feature Matrix UITest Cases for Shadows (#27701) * Added sample to Matrix UITest Cases for Shadow * Renamed sample page * Renamed sample page * More tests * More tests * More tests * More tests * Added shadow tests * Updated sample * Added Windows snapshots * Updated tests * Added link to issue * More changes * Updated sample reset logic * Updated sample * More changes * More changes * More changes * Updated sample * Added snapshots * Hide cursor * More changes * More snapshots * Updated tests * Updated iOS snapshots * Updated iOS snapshots * Updated snapshots * Updated snapshots * Updated tests * [housekeeping] Automated PR to fix formatting errors on uitest-shadow-feature * Updated tests * Fix build errors * More changes * More changes * More changes * More changes --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [iOS] Fixed Shell.SearchHandler ClearPlaceholderIcon Color Issue (#28601) * SearchHandler ClearPlaceholderIcon color fix * Added Mac snapshot * Updated SearchBar Icon changes * Test script changes. * Revert unwanted changes * Updated custom icon changes * Fix -[iOS] - CarouselView Throws ArgumentOutOfRangeException Immediately on Application Launch in CV2 (#29316) * Update ItemsSourceFactory2.cs * Update CarouselViewPositionVisibility.xaml * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView (#29660) * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView * Have added test case * Updated AutomationId for better clarity and readability * Have modified the context of the description label * Have committed the snapshots * [Testing] Feature Matrix UITest Cases for Label (#29690) * Added Label Feature tests * changes updated * changes updated * changes updated * Added Screenshots * Added Snapshots for iOS * Corrected Mistakes * Added snapshots * Added images * Renamed file --------- Co-authored-by: Rui Marinho <me@ruimarinho.net> * updated base images for candidate PR failures (#29766) * [Android] Fix: Modal Animation Repeats When Returning from Background 3 (#29702) * fix * dispose listner once not needed * Revert "dispose listner once not needed" * call invalidate * add device test to check for leaks * null check and remove strong references in callback * Throw if rootview is null before adding animation * fix spelling mistake * [Testing] Include a tolerance parameter in the Verifyscreenshot method (#29776) * Added tolerance parameter to the VerifyScreenshot method * More changes * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * [Testing] Update Appium to v8 (#29774) * Update Appium to the latest version * Removed deprecated logic * Update comment * [create-pull-request] automated change (#29831) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Perf : ButtonContentTypeConverter now using InvariantCulture to parse double --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Tamilarasan Paranthaman <93904422+Tamilarasan-Paranthaman@users.noreply.github.com> Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: Paul Anderson <42271912+PaulAndersonS@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com> Co-authored-by: devanathan-vaithiyanathan <114395405+devanathan-vaithiyanathan@users.noreply.github.com> Co-authored-by: Subhiksha Chandrasekaran <subhiksha.c@syncfusion.com> Co-authored-by: BagavathiPerumal <93652794+BagavathiPerumal@users.noreply.github.com> Co-authored-by: prakashKannanSf3972 <127308739+prakashKannanSf3972@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: SuthiYuvaraj <92777079+SuthiYuvaraj@users.noreply.github.com> Co-authored-by: SyedAbdulAzeemSF4852 <syedabdulazeem.a@syncfusion.com> Co-authored-by: Anandhan Rajagopal <97146406+anandhan-rajagopal@users.noreply.github.com> Co-authored-by: Bhavanesh N <bhavanesh001@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com>

Fix-view-position-shift-when-toggling-shadows

b43bf81

dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels May 27, 2025

jsuarezruiz added platform/windows area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing labels May 27, 2025

prakashKannanSf3972 marked this pull request as ready for review May 27, 2025 11:26

Copilot AI review requested due to automatic review settings May 27, 2025 11:26

prakashKannanSf3972 requested a review from a team as a code owner May 27, 2025 11:26

prakashKannanSf3972 requested review from PureWeen and rmarinho May 27, 2025 11:26

Copilot AI reviewed May 27, 2025

View reviewed changes

Added-Pending-SnapShots

3ad6e3e

Resaved-image

6304569

jsuarezruiz approved these changes May 30, 2025

View reviewed changes

rmarinho changed the base branch from main to inflight/current May 30, 2025 17:08

rmarinho merged commit 62f33e6 into dotnet:inflight/current May 30, 2025
78 checks passed

rmarinho pushed a commit that referenced this pull request May 30, 2025

[Windows] - Fix view position shift when shadows are added or removed…

62887fd

… at runtime (#29681) * Fix-view-position-shift-when-toggling-shadows * Added-Pending-SnapShots * Resaved-image

PureWeen pushed a commit that referenced this pull request Jun 3, 2025

[Windows] - Fix view position shift when shadows are added or removed…

907d603

… at runtime (#29681) * Fix-view-position-shift-when-toggling-shadows * Added-Pending-SnapShots * Resaved-image

MartyIX mentioned this pull request Jun 13, 2025

[Windows] Fix performance issue using Shadows #18337

Draft

bronteq mentioned this pull request Jun 13, 2025

View changes position when adding/removing Shadows at runtime #27732

Open

github-actions bot locked and limited conversation to collaborators Jun 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Windows] - Fix view position shift when shadows are added or removed at runtime #29681

[Windows] - Fix view position shift when shadows are added or removed at runtime #29681

Uh oh!

prakashKannanSf3972 commented May 27, 2025

Uh oh!

dotnet-policy-service bot commented May 27, 2025

Uh oh!

jsuarezruiz commented May 27, 2025

Uh oh!

azure-pipelines bot commented May 27, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

jsuarezruiz commented May 28, 2025

Uh oh!

azure-pipelines bot commented May 28, 2025

Uh oh!

jsuarezruiz commented May 29, 2025

Uh oh!

azure-pipelines bot commented May 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[Windows] - Fix view position shift when shadows are added or removed at runtime #29681

[Windows] - Fix view position shift when shadows are added or removed at runtime #29681

Uh oh!

Conversation

prakashKannanSf3972 commented May 27, 2025

Root Cause

Description of Change

Regressed PR

Issues Fixed

Output

Uh oh!

dotnet-policy-service bot commented May 27, 2025

Uh oh!

jsuarezruiz commented May 27, 2025

Uh oh!

azure-pipelines bot commented May 27, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

jsuarezruiz commented May 28, 2025

Uh oh!

azure-pipelines bot commented May 28, 2025

Uh oh!

jsuarezruiz commented May 29, 2025

Uh oh!

azure-pipelines bot commented May 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants