[iOS] Fixed Shell.SearchHandler ClearPlaceholderIcon Color Issue #28601

Tamilarasan-Paranthaman · 2025-03-25T10:55:14Z

Root Cause of the issue

Issue 1: The ClearPlaceholderIcon color was not updated properly:

The ClearPlaceholderIcon color was being updated correctly in the source, similar to other icon colors, by retrieving the UIButton from the UITextField. However, the UIButton was null at the time of retrieval, preventing the color from being properly applied to the image view.

Issue 2: An exception occurred when setting a custom ClearPlaceholderIcon:

The exception was thrown because the ImageSource could not find its parent since it does not have any parent yet while attempting to retrieve the MauiContext.

Description of Change

Issue 1: The ClearPlaceholderIcon color was not updated properly:

The issue occurred because the UIButton had not yet been added to the UITextField when accessed; it was only available in the UITextField's RightView. This happened because the colors were being updated in PageAppearing, at which point the UIButton was not yet present in the UITextField. To resolve this, I moved the SearchBar color update to the OnPageLoaded event, similar to how toolbar items are updated. This ensures that the UIButton is properly retrieved, resolving the issue.

Issue 2: An exception occurred when setting a custom ClearPlaceholderIcon:

I resolved this issue by retrieving the MauiContext from the respective Page or Shell, similar to how it is used when updating the LeftToolbarItems.

Issues Fixed

Fixes #20250
Fixes #14442

Tested the behaviour in the following platforms

iOS
Android
Windows
Mac

Screenshot

Before Fix	After Fix
Before-Fix.mov	After-Fix.mov
Before-Fix-Custom-Icon.mov	After-Fix-Custom-Icon.mov

…n/maui into fix-20250

dotnet-policy-service · 2025-03-25T10:55:40Z

Hey there @Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

jsuarezruiz · 2025-03-25T11:27:40Z

/azp run

azure-pipelines · 2025-03-25T11:28:01Z

Azure Pipelines successfully started running 3 pipeline(s).

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20250.cs

jsuarezruiz

Pending snapshots already available.

Could you commit the images?

Tamilarasan-Paranthaman · 2025-03-26T07:58:46Z

Pending snapshots already available.

Could you commit the images?

@jsuarezruiz, I have added the pending Mac image.

jsuarezruiz · 2025-03-27T06:56:11Z

/azp run

azure-pipelines · 2025-03-27T06:56:31Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-04-07T08:11:16Z

/rebase

jsuarezruiz · 2025-04-08T07:48:17Z

/azp run

azure-pipelines · 2025-04-08T07:48:39Z

Azure Pipelines successfully started running 3 pipeline(s).

src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs

jsuarezruiz · 2025-04-23T11:53:41Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-04-23T11:53:52Z

Azure Pipelines successfully started running 1 pipeline(s).

src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs

jsuarezruiz · 2025-05-27T08:10:33Z

/azp run

azure-pipelines · 2025-05-27T08:10:53Z

Azure Pipelines successfully started running 3 pipeline(s).

) * SearchHandler ClearPlaceholderIcon color fix * Added Mac snapshot * Updated SearchBar Icon changes * Test script changes. * Revert unwanted changes * Updated custom icon changes

#25393) * [create-pull-request] automated change (#29793) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Convert HybridWebView.js to TypeScript and embed (#27183) * Fix up relevant CA1416 warnings - Set 3 (#26751) * [Testing] Feature Matrix UITest Cases for CollectionView Dynamic changes (#29424) * Added FeatureTests for CollectionView * changes updated * changes updated * [create-pull-request] automated change (#29505) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * CA1416 warning fix * Added snapshots * Reverting files changes * Removed the old approach * Revert unwanted changes * Reverted unwanted changes * Reverted unwanted changes * Revert unwanted changes --------- Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix up relevant CA1416 warnings - Set 1 (#26696) * Changed Syncfusion toolkit version from 1.0.4 to 1.0.5 (#29659) * [ci] Update dependencies from 9.0.4 to 9.0.5 (#29667) * [ci] Update dependencies from 9.0.4 to 9.0.5 * Update the net8 version * Add missing version MicrosoftJSInteropPackageVersion * Page.OnBackButtonPressed remove outdated API documentation (#29543) * Fixed KeepLastItemInView Does Not Scroll to Last Item When Adding Items at Top (#29632) * Fixed KeepLastItem not scrolled to last item * Updated Fix * Updated test sample * Added comment line * Updated test sample for iOS and mac * Added Snapshots for android and WinUI * Added UI tests. * Test sample changes. * script changes * script changes * Added snapshots * Resaved Mac images and the gradient image size issue has been fixed * CA1416 warning changes * Reverted unwanted changes --------- Co-authored-by: Paul Anderson <42271912+PaulAndersonS@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com> * [iOS/Mac]Fix StrokeDashArray Property not Rendering (#29670) * fix added * Test added * snap added * [Android/ iOS] Fix Flyout icon is displayed when flyout is disabled (#29637) * fix added * modified the fix * test case added * test case added * summary added * Script name changed * [Android & iOS] Fix for SearchHandler Character Spacing Property (#29497) * [Android & iOS] Fix for character spacing in searchHandler * Updated test sample concerns * Update on naming * Update on formatting * Allowing updating character spacing to zero * Updated Andorid, iOS, Mac images * [create-pull-request] automated change (#29724) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Windows] Fix for SearchHandler Visibility Not Updating During In-Section Navigation (#29441) * fix-17521-Updates the SearchHandler when navigating to another page within same ShellSection. * fix-17521-Added testcase and added snapshot for Android and iOS. * fix-17521-Renamed Shell_Navigated to OnShellNavigated. * fix-17521-Modified the Location string value from "Ethopia" to "Ethiopia". * fix-17521-Snapshot updated. * fix-17521-Updated Windows and Mac Snapshot. * [Windows] - Fix view position shift when shadows are added or removed at runtime (#29681) * Fix-view-position-shift-when-toggling-shadows * Added-Pending-SnapShots * Resaved-image * [Testing] Feature Matrix UITest Cases for Shadows (#27701) * Added sample to Matrix UITest Cases for Shadow * Renamed sample page * Renamed sample page * More tests * More tests * More tests * More tests * Added shadow tests * Updated sample * Added Windows snapshots * Updated tests * Added link to issue * More changes * Updated sample reset logic * Updated sample * More changes * More changes * More changes * Updated sample * Added snapshots * Hide cursor * More changes * More snapshots * Updated tests * Updated iOS snapshots * Updated iOS snapshots * Updated snapshots * Updated snapshots * Updated tests * [housekeeping] Automated PR to fix formatting errors on uitest-shadow-feature * Updated tests * Fix build errors * More changes * More changes * More changes * More changes --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [iOS] Fixed Shell.SearchHandler ClearPlaceholderIcon Color Issue (#28601) * SearchHandler ClearPlaceholderIcon color fix * Added Mac snapshot * Updated SearchBar Icon changes * Test script changes. * Revert unwanted changes * Updated custom icon changes * Fix -[iOS] - CarouselView Throws ArgumentOutOfRangeException Immediately on Application Launch in CV2 (#29316) * Update ItemsSourceFactory2.cs * Update CarouselViewPositionVisibility.xaml * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView (#29660) * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView * Have added test case * Updated AutomationId for better clarity and readability * Have modified the context of the description label * Have committed the snapshots * [Testing] Feature Matrix UITest Cases for Label (#29690) * Added Label Feature tests * changes updated * changes updated * changes updated * Added Screenshots * Added Snapshots for iOS * Corrected Mistakes * Added snapshots * Added images * Renamed file --------- Co-authored-by: Rui Marinho <me@ruimarinho.net> * updated base images for candidate PR failures (#29766) * [Android] Fix: Modal Animation Repeats When Returning from Background 3 (#29702) * fix * dispose listner once not needed * Revert "dispose listner once not needed" * call invalidate * add device test to check for leaks * null check and remove strong references in callback * Throw if rootview is null before adding animation * fix spelling mistake * [Testing] Include a tolerance parameter in the Verifyscreenshot method (#29776) * Added tolerance parameter to the VerifyScreenshot method * More changes * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * [Testing] Update Appium to v8 (#29774) * Update Appium to the latest version * Removed deprecated logic * Update comment * [create-pull-request] automated change (#29831) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Perf : ButtonContentTypeConverter now using InvariantCulture to parse double --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Tamilarasan Paranthaman <93904422+Tamilarasan-Paranthaman@users.noreply.github.com> Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: Paul Anderson <42271912+PaulAndersonS@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com> Co-authored-by: devanathan-vaithiyanathan <114395405+devanathan-vaithiyanathan@users.noreply.github.com> Co-authored-by: Subhiksha Chandrasekaran <subhiksha.c@syncfusion.com> Co-authored-by: BagavathiPerumal <93652794+BagavathiPerumal@users.noreply.github.com> Co-authored-by: prakashKannanSf3972 <127308739+prakashKannanSf3972@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: SuthiYuvaraj <92777079+SuthiYuvaraj@users.noreply.github.com> Co-authored-by: SyedAbdulAzeemSF4852 <syedabdulazeem.a@syncfusion.com> Co-authored-by: Anandhan Rajagopal <97146406+anandhan-rajagopal@users.noreply.github.com> Co-authored-by: Bhavanesh N <bhavanesh001@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com>

Tamilarasan-Paranthaman added 2 commits March 25, 2025 14:58

SearchHandler ClearPlaceholderIcon color fix

35e0936

Merge branch 'fix-20250' of https://github.com/Tamilarasan-Paranthama…

28e342e

…n/maui into fix-20250

dotnet-policy-service bot added the community ✨ Community Contribution label Mar 25, 2025

dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Mar 25, 2025

jsuarezruiz added platform/ios area-controls-shell Shell Navigation, Routes, Tabs, Flyout labels Mar 25, 2025

jsuarezruiz requested changes Mar 25, 2025

View reviewed changes

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20250.cs Outdated Show resolved Hide resolved

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20250.cs Outdated Show resolved Hide resolved

jsuarezruiz requested changes Mar 26, 2025

View reviewed changes

Added Mac snapshot

429699f

Tamilarasan-Paranthaman marked this pull request as ready for review March 26, 2025 07:59

Tamilarasan-Paranthaman requested a review from a team as a code owner March 26, 2025 07:59

Tamilarasan-Paranthaman requested review from PureWeen and StephaneDelcroix March 26, 2025 07:59

github-actions bot force-pushed the fix-20250 branch from 429699f to 68d08f9 Compare April 7, 2025 08:11

jsuarezruiz requested changes Apr 16, 2025

View reviewed changes

src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs Outdated Show resolved Hide resolved

Updated SearchBar Icon changes

0cb8dde

Tamilarasan-Paranthaman force-pushed the fix-20250 branch from 68d08f9 to 0cb8dde Compare April 16, 2025 11:55

Tamilarasan-Paranthaman added 2 commits April 16, 2025 17:36

Test script changes.

e38ace8

Revert unwanted changes

4a61ff0

jsuarezruiz reviewed May 20, 2025

View reviewed changes

src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs Outdated Show resolved Hide resolved

Updated custom icon changes

60d2bfd

jsuarezruiz approved these changes May 30, 2025

View reviewed changes

rmarinho changed the base branch from main to inflight/current May 30, 2025 17:10

rmarinho added this to the .NET 9 SR8 milestone May 30, 2025

rmarinho added this to MAUI SDK Ongoing May 30, 2025

github-project-automation bot moved this to Todo in MAUI SDK Ongoing May 30, 2025

rmarinho moved this from Todo to Approved in MAUI SDK Ongoing May 30, 2025

rmarinho merged commit 0d08470 into dotnet:inflight/current May 30, 2025
130 of 131 checks passed

github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing May 30, 2025

github-actions bot locked and limited conversation to collaborators Jun 30, 2025

Tamilarasan-Paranthaman deleted the fix-20250 branch September 24, 2025 07:13

[iOS] Fixed Shell.SearchHandler ClearPlaceholderIcon Color Issue #28601

[iOS] Fixed Shell.SearchHandler ClearPlaceholderIcon Color Issue #28601

Uh oh!

Conversation

Tamilarasan-Paranthaman commented Mar 25, 2025

Root Cause of the issue

Issue 1: The ClearPlaceholderIcon color was not updated properly:

Issue 2: An exception occurred when setting a custom ClearPlaceholderIcon:

Description of Change

Issue 1: The ClearPlaceholderIcon color was not updated properly:

Issue 2: An exception occurred when setting a custom ClearPlaceholderIcon:

Issues Fixed

Tested the behaviour in the following platforms

Screenshot

Uh oh!

dotnet-policy-service bot commented Mar 25, 2025

Uh oh!

jsuarezruiz commented Mar 25, 2025

Uh oh!

azure-pipelines bot commented Mar 25, 2025

Uh oh!

Uh oh!

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

Tamilarasan-Paranthaman commented Mar 26, 2025

Uh oh!

jsuarezruiz commented Mar 27, 2025

Uh oh!

azure-pipelines bot commented Mar 27, 2025

Uh oh!

jsuarezruiz commented Apr 7, 2025

Uh oh!

jsuarezruiz commented Apr 8, 2025

Uh oh!

azure-pipelines bot commented Apr 8, 2025

Uh oh!

Uh oh!

jsuarezruiz commented Apr 23, 2025

Uh oh!

azure-pipelines bot commented Apr 23, 2025

Uh oh!

Uh oh!

jsuarezruiz commented May 27, 2025

Uh oh!

azure-pipelines bot commented May 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants