Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAUI] Select items traces are preserved #26187

Closed
ninachen03 opened this issue Nov 28, 2024 · 2 comments · Fixed by #26315
Closed

[MAUI] Select items traces are preserved #26187

ninachen03 opened this issue Nov 28, 2024 · 2 comments · Fixed by #26315
Assignees
@rmarinho
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView csi-new fixed-in-9.0.21 i/regression This issue described a confirmed regression on a currently supported version p/0 Work that we can't release without platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone
.NET 9 SR2

Comments

@ninachen03
Copy link

ninachen03 commented Nov 28, 2024 •
edited
Loading

Description

[MAUI]
Affected case: All test cases

Steps to Reproduce

  1. Deploy https://devdiv.visualstudio.com/Pkgs/_git/VS.TestAssets.Xaml?path=/Assets/Projects/ManualMauiTests to iOS or MacCatalyst.
  2. Click any categories EG: "C RefreshView "-> C1 or others.
  3. Back to C1 you will see the C1 display gray
  4. Back to categories, you will see the "C RefreshView" show gray too.

Actual Behavior:
Image
Expected Behavior:
Selection trace disappears and should not be retained
Image

Link to public reproduction project repository

https://devdiv.visualstudio.com/Pkgs/_git/VS.TestAssets.Xaml?path=/Assets/Projects/ManualMauiTests

Version with bug

Microsoft.Maui.Controls: 9.0.20-ci.main.24577.4

Is this a regression from previous behavior?

Yes, this used to work in .NET MAUI

Last version that worked well

Microsoft.Maui.Controls: 9.0.20-ci.main.24573.3

Affected platforms

iOS, macOS
@ninachen03 ninachen03 added csi-new i/regression This issue described a confirmed regression on a currently supported version platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working labels Nov 28, 2024
@rmarinho
Copy link
Member

Can you check if it behave the same on Android and Windows ?

@rmarinho rmarinho mentioned this issue Nov 28, 2024
Closed
@rmarinho rmarinho added this to the .NET 9 SR2 milestone Nov 28, 2024
@rmarinho rmarinho moved this from Todo to In Progress in MAUI SDK Ongoing Nov 28, 2024
@ninachen03
Copy link
Author

Can you check if it behave the same on Android and Windows ?

Can't reproduce on Android and Windows platforms, as I mentioned above, only affects iOS, macOS

rmarinho added a commit that referenced this issue Dec 2, 2024
@rmarinho
Add sample for issue #26187
49216c4
@rmarinho rmarinho mentioned this issue Dec 2, 2024
Merged
rmarinho added a commit that referenced this issue Dec 3, 2024
@rmarinho
Add sample for issue #26187
6f9464b
rmarinho added a commit that referenced this issue Dec 3, 2024
@rmarinho
[testing] Add uitest for issue #26187
2368ab8
rmarinho added a commit that referenced this issue Dec 4, 2024
@rmarinho
Add sample for issue #26187
a3651d3
rmarinho added a commit that referenced this issue Dec 4, 2024
@rmarinho
[testing] Add uitest for issue #26187
7f89acc
@PureWeen PureWeen added the p/0 Work that we can't release without label Dec 4, 2024
PureWeen pushed a commit that referenced this issue Dec 6, 2024
@rmarinho
[iOS] Fix deselect item on CollectionView (#26315)
66982c3 
* Add sample for issue #26187

* [iOS] Fix deselecting an item

* [testing] Add uitest for issue #26187

* [testing] Add android screenshot

* [testing] Add missing image windows

* [ios] Add foreach inside CollectionView.PerformBatchUpdates

* Update SelectableItemsViewController.cs

* [iOS] Don try to update empty if no items

* Fix sample
@github-project-automation github-project-automation bot moved this from In Progress to Done in MAUI SDK Ongoing Dec 6, 2024
@CathyZhu0110 CathyZhu0110 added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmarinho rmarinho

Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView csi-new fixed-in-9.0.21 i/regression This issue described a confirmed regression on a currently supported version p/0 Work that we can't release without platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
MAUI SDK Ongoing
Status: Done
Milestone
.NET 9 SR2
5 participants
@rmarinho @PureWeen @samhouts @CathyZhu0110 @ninachen03