-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Fixed CollectionView SelectedItem binding issue on initial loading" #26212
Conversation
…ading (#…" This reverts commit 60976d1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to also open the original issues again?
@SuthiYuvaraj are you able to have a look at the initial PR and see why the selection state was not reset? |
Hi @mattleibow , Additionally, testing was carried out using the SelectionChanged event. In this case, the selection was not reset during navigation. However, this behavior was observed regardless of whether the fix was applied. To better understand the issue, Kindly modify the attached code or any additional information about the replication procedure or inputs regarding the sample would be highly beneficial in identifying the root cause and resolving the issue with selection state. Reason for Regression: Regarding Windows Fix: |
Hello @SuthiYuvaraj we have an example here https://github.com/dotnet/maui/tree/fix-26187 the problem is when going back we still see the SelectedItem even after setting to null after pushing a new page., I understand we aren-t changing he selection, but this change is changing the behaviour in some way . |
@SuthiYuvaraj I think I have a fix here #26315 can you review please ? |
@mattleibow This PR #26315 addresses the deselection issue effectively, so reverting the changes is unnecessary. Kindly proceed with closing it. |
Reverts #25555
Fixes #26187