Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fixed CollectionView SelectedItem binding issue on initial loading" #26212

Closed
wants to merge 1 commit into from

Conversation

rmarinho
Copy link
Member

Reverts #25555

Fixes #26187

@rmarinho rmarinho requested a review from a team as a code owner November 28, 2024 22:20
@rmarinho rmarinho requested review from Eilon and jfversluis November 28, 2024 22:20
@rmarinho rmarinho added this to the .NET 9 SR2 milestone Nov 28, 2024
@rmarinho rmarinho added the i/regression This issue described a confirmed regression on a currently supported version label Nov 28, 2024
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to also open the original issues again?

@mattleibow
Copy link
Member

@SuthiYuvaraj are you able to have a look at the initial PR and see why the selection state was not reset?

@SuthiYuvaraj
Copy link
Contributor

@SuthiYuvaraj are you able to have a look at the initial PR and see why the selection state was not reset?

Hi @mattleibow ,
Sample Inaccessibility:
The sample provided in the issue report was inaccessible. Therefore, testing was conducted using a newly created sample where the selection mode was set to "Single," and navigation was handled within the Tapped event of the template. The selection functionality performed as expected, both with and without the applied fix, and the selected state was not retained in the view after navigation.

Additionally, testing was carried out using the SelectionChanged event. In this case, the selection was not reset during navigation. However, this behavior was observed regardless of whether the fix was applied.

To better understand the issue, Kindly modify the attached code or any additional information about the replication procedure or inputs regarding the sample would be highly beneficial in identifying the root cause and resolving the issue with selection state.

Reason for Regression:
Could you please clarify why this PR is considered a regression? Since no changes were made to update or reset the selection, further details would help address the concern effectively.

Regarding Windows Fix:
The reported issue does not occur on Windows platforms. Since the Windows-specific fix has been reverted in this PR, could you please remove the code changes related to the Windows platform? This will help maintain clarity and ensure only relevant updates are included.

@rmarinho
Copy link
Member Author

rmarinho commented Dec 2, 2024

Hello @SuthiYuvaraj we have an example here https://github.com/dotnet/maui/tree/fix-26187 the problem is when going back we still see the SelectedItem even after setting to null after pushing a new page., I understand we aren-t changing he selection, but this change is changing the behaviour in some way .

@rmarinho
Copy link
Member Author

rmarinho commented Dec 2, 2024

@SuthiYuvaraj I think I have a fix here #26315 can you review please ?

@rmarinho rmarinho added the do-not-merge Don't merge this PR label Dec 2, 2024
@SuthiYuvaraj
Copy link
Contributor

@SuthiYuvaraj I think I have a fix here #26315 can you review please ?

@mattleibow This PR #26315 addresses the deselection issue effectively, so reverting the changes is unnecessary. Kindly proceed with closing it.

@rmarinho rmarinho closed this Dec 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do-not-merge Don't merge this PR i/regression This issue described a confirmed regression on a currently supported version
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[MAUI] Select items traces are preserved
3 participants