Ensure iOS always has the required splash storyboard #12677
Conversation
mattleibow
changed the title
| <!-- UWP / WinUI --> | ||
| <PropertyGroup Condition="'$(_ResizetizerIsUWPApp)' == 'True' Or '$(_ResizetizerIsWindowsAppSdk)' == 'True'"> | ||
| <!-- Windows App SDK --> | ||
| <PropertyGroup Condition="'$(_ResizetizerIsWindowsAppSdk)' == 'True'"> |
There was a problem hiding this comment.
Just cleaning up comments and conditions. The $(_ResizetizerIsUWPApp) property was removed some time ago.
| <PropertyGroup> | ||
| <_MauiHasSplashScreens>false</_MauiHasSplashScreens> | ||
| <_MauiHasSplashScreens Condition="'@(MauiSplashScreen->Count())' != '0'">true</_MauiHasSplashScreens> | ||
| </PropertyGroup> |
There was a problem hiding this comment.
The is partially the fix. Since apps may need a splash in order to launch right, we actually always want to process a splash and create an empty one if none was found. For now, the other platforms have "ok" fallbacks - windows/maccat do not support splash, android just used the primary color and tizen needs to be tested still.
However, iOS always requires one so this PR makes this target always run, we just skip the steps for the other platforms. When building for iOS, we run the tasks as if we had a splash, and when the actual task is running it determines no splash was provided so generates an empty one.
This may also be nice if we detect no splash on Android, we can just use the app icon. But for now, this PR is for iOS.
|
/backport to net7.0 |
|
Started backporting to net7.0: https://github.com/dotnet/maui/actions/runs/4016833621 |
samhouts
added
the
fixed-in-8.0.0-preview.1.7762
Description of Change
Make sure iOS always has a splash screen as this is required to tell the OS that this is a "modern" app and can use the full screen.
Issues Fixed
Fixes #11951
Fixes #14421