Improve the control over resource generation #16845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
The logic looks ok, I mainly had questions about naming.
...SingleProject/Resizetizer/src/nuget/buildTransitive/Microsoft.Maui.Resizetizer.After.targets
Outdated
Show resolved
Hide resolved
...SingleProject/Resizetizer/src/nuget/buildTransitive/Microsoft.Maui.Resizetizer.After.targets
Outdated
Show resolved
Hide resolved
...SingleProject/Resizetizer/src/nuget/buildTransitive/Microsoft.Maui.Resizetizer.After.targets
Outdated
Show resolved
Hide resolved
| </Target> | ||
|
|
||
| <Target Name="ResizetizeImages" | ||
| Condition="'$(EnableMauiImageProcessing)' != 'false'" |
Member
There was a problem hiding this comment.
The only other thought, is we generally document every MSBuild property that is public, such as this doc that is synced with MS docs:
Should we prefix all these values with _ to make them private, but useable? Or is there a decent place to document them? Like:
https://github.com/dotnet/maui/blob/main/src/Workload/README.md
Member
Author
There was a problem hiding this comment.
I think I want public, but not sure I am ready to commit.
Member
Author
|
/rebase |
github-actions
bot
force-pushed
the
dev/maui-splash
branch
from
6724a3e to
1020c94
Compare
Contributor
|
Related: #14421 |
Member
Author
|
Some black splash screens are a result of dotnet/macios#18777 |
jonathanpeppers
approved these changes
Aug 21, 2023
hartez
approved these changes
Aug 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Previously, there was an issue where if you deleted the
<MauiSplashScreen>item and did NOT have a custom splash screen, then the iOS app would render incorrectly:This is not great behavior, so we went and added a way to automatically generate a splash screen for you if we detected that you did not have one:
This made things amazing again, except if you want to have a custom splash screen from a storyboard:
As a result, this PR is partially "reverting" the change because having no way to override the splash screen is worse than having a weird looking app that you will need to fix anyway for the App Store.
This PR has a few things actually:
<EnableMauiAssetProcessing>can stop the packaging of any<MauiAsset>items<EnableMauiSplashScreenProcessing>can stop the packaging of any<MauiSplashScreen>items<EnableMauiFontProcessing>can stop the packaging of any<MauiFont>items<EnableMauiImageProcessing>can stop the packaging of any<MauiImage>items<EnableBlankMauiSplashScreen>will generate a blank splash screen if no<MauiSplashScreen>items were found. This will override any custom splash screens and may/probably will cause an App Store rejection. But, it is useful in testing to ensure the app UI is correct.Issues Fixed
Fixes #16843