Add animated GIF support for Image on iOS #19411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
dev/gif-investigations
branch
from
f606b54 to
744aa56
Compare
mattleibow
force-pushed
the
dev/gif-investigations
branch
from
744aa56 to
07898c3
Compare
mattleibow
force-pushed
the
dev/gif-investigations
branch
2 times, most recently
from
c439ba6 to
11b870c
Compare
github-actions
bot
force-pushed
the
dev/gif-investigations
branch
2 times, most recently
from
3a81b58 to
12851a6
Compare
mattleibow
force-pushed
the
dev/gif-investigations
branch
2 times, most recently
from
114b909 to
3c0f9d9
Compare
|
/rebase |
github-actions
bot
force-pushed
the
dev/gif-investigations
branch
from
3c0f9d9 to
8ca1d0d
Compare
mattleibow
force-pushed
the
dev/gif-investigations
branch
from
8ca1d0d to
8891e23
Compare
mattleibow
changed the title
samhouts
added
platform/iOS 🍎
and removed
stale
mattleibow
force-pushed
the
dev/gif-investigations
branch
from
8891e23 to
baeaeee
Compare
github-actions
bot
force-pushed
the
dev/gif-investigations
branch
from
baeaeee to
cb8f412
Compare
|
Do you expect that the ImageButton version with the gif should be playing as well? GifSample.mov |
mattleibow
commented
Feb 15, 2024
PureWeen
reviewed
Feb 15, 2024
PureWeen
reviewed
Feb 15, 2024
PureWeen
reviewed
Feb 15, 2024
src/Core/src/ImageSources/FileImageSourceService/FileImageSourceService.iOS.cs
Show resolved
Hide resolved
mattleibow
force-pushed
the
dev/gif-investigations
branch
from
cb8f412 to
0ac72a1
Compare
PureWeen
approved these changes
Feb 16, 2024
|
Failing tests unrelated |
Eilon
added
area-controls-image
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is an alternate take on #17207 using the ideas from FFImageLoading.
Issues Fixed
Fixes #866
Depends on: