Adding a test to validate loading images #20147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
reviewed
Jan 25, 2024
mattleibow
force-pushed
the
dev/image-loading-tests
branch
2 times, most recently
from
9932aa2
to
75c65b5
Compare
|
Waiting on #20169 |
mattleibow
force-pushed
the
dev/image-loading-tests
branch
from
75c65b5
to
74c76ec
Compare
github-actions
bot
force-pushed
the
dev/image-loading-tests
branch
from
74c76ec
to
178592d
Compare
mattleibow
force-pushed
the
dev/image-loading-tests
branch
from
178592d
to
65c3e74
Compare
github-actions
bot
force-pushed
the
dev/image-loading-tests
branch
from
65c3e74
to
82cd138
Compare
I noticed that in one of my PRs I loaded a lower res image and another test caught it. Adding these tests to ensure that at least we validate the on-screen image.
github-actions
bot
force-pushed
the
dev/image-loading-tests
branch
from
82cd138
to
799ef5e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
I noticed that in one of my PRs I loaded a lower res image and another test caught it. Adding these tests to ensure that at least we validate the on-screen image.
Depends on: