[Android] DatePicker Focus and Unfocus events #20547

kubaflo · 2024-02-13T13:25:27Z

Description of Change

Added DatePicker Focus and Unfocus events

Issues Fixed

Demo
Screen.Recording.2024-02-13.at.14.23.34.mov

ghost · 2024-02-13T13:25:36Z

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

jsuarezruiz · 2024-02-22T10:58:28Z

If we apply these changes, we should apply them to the TimePicker.

jsuarezruiz

Could replicate the same changes in the TimePicker?

kubaflo · 2024-02-22T12:45:05Z

@jsuarezruiz sure! I've added a commit with this

src/Core/src/Handlers/TimePicker/TimePickerHandler.Android.cs

src/Core/src/Handlers/DatePicker/DatePickerHandler.Android.cs

jonathanpeppers

Changes LGTM now. 👍

We should check the new test passed when CI is done.

jsuarezruiz · 2024-03-21T10:30:02Z

/azp run MAUI-UITests-public

azure-pipelines · 2024-03-21T10:30:14Z

Azure Pipelines successfully started running 1 pipeline(s).

mos379 · 2024-04-30T09:55:53Z

@PureWeen @tj-devel709 how about reviewing this?

jsuarezruiz · 2024-05-10T09:11:14Z

/azp run

azure-pipelines · 2024-05-10T09:11:34Z

Azure Pipelines successfully started running 3 pipeline(s).

pmigliore · 2024-05-28T13:53:32Z

Hi, me and my team are migrating our Xamarin app to MAUI, and we need this feature to move forward, if anyone could take a look at this PR, thanks

jsuarezruiz · 2024-06-13T07:13:53Z

/azp run

danbrannanavontus · 2024-08-13T10:12:25Z

Hi - as I understand it this fix hasn't made it into the release due to a merge issue. Would it be possible to get this looked at as this issue is causing a headache for us. Thanks

Dan

brinawebb · 2024-08-13T14:38:26Z

Hello Maui team. Is there any way this merge can be reviewed/approved? We are trying to convert our mobile project from Xamarin and this issue is preventing us from doing so. Should be a simple approval. Thank you!

ryanaw83 · 2024-08-13T14:46:51Z

This fix is needed... will it be merged soon?

PureWeen · 2024-09-07T00:50:39Z

/azp run

azure-pipelines · 2024-09-07T00:50:58Z

Azure Pipelines successfully started running 3 pipeline(s).

mos379 · 2024-11-15T08:30:32Z

@kubaflo nice!

jsuarezruiz · 2024-11-15T09:22:31Z

/azp run

azure-pipelines · 2024-11-15T09:22:51Z

Azure Pipelines successfully started running 3 pipeline(s).

bhavanesh2001 · 2025-04-17T18:27:15Z

@PureWeen Just to confirm — based on this #28122 (comment), does this mean the PR won’t be moving forward?

mattleibow · 2025-05-30T23:23:59Z

@PureWeen Just to confirm — based on this #28122 (comment), does this mean the PR won’t be moving forward?

I think the PRs are different. The other one did this:

PlatformView?.ClearFocus();

It actually changed the focus on the control.

This PR just updates the state in the virtual/xaml view so we get events.

However, this does still mean we need to verify that it does not cause issues. @PureWeen did you have an actual physical keyboard (on the desk) or is there a "virtual physical" keyboard that we can use to test?

mattleibow

I am approving this with regards to code and logic and how things "should" work. However, it would be great to get someone with a physical keyboard on their phone to confirm that it does not crash the app or have some focus loops.

mattleibow · 2025-05-30T23:25:21Z

/rebase

mattleibow · 2025-05-30T23:26:19Z

/azp run

azure-pipelines · 2025-05-30T23:26:38Z

Azure Pipelines successfully started running 3 pipeline(s).

bhavanesh2001

The control isn’t a true platform input — it's a mix of AppCompatEditText and a dialog. Since nothing is actually focused at the platform level when the dialog is shown, mapping IsFocused to dialog show/dismiss is misleading.

In the case of Picker, a lot of custom wiring was done (like making EditText focusable on touch) just to make focus/unfocus work — which ended up causing subtle bugs: #29068 (comment)

Just wanted to flag this, With #29323 shaping up for .NET 10, might be worth aligning with that direction.

PureWeen

pausing based on this comment

#20547 (review)

Do we still need this PR since we are adding APIS in NET10 for opening and closing pickers?

PureWeen · 2025-06-20T17:50:41Z

Closing this in favor of APIs we're adding into .NET 10
#29323

kubaflo requested a review from a team as a code owner February 13, 2024 13:25

kubaflo requested review from jsuarezruiz and tj-devel709 February 13, 2024 13:25

ghost added the community ✨ Community Contribution label Feb 13, 2024

jsuarezruiz added the area-controls-datetimepicker DatePicker, TimePicker label Feb 13, 2024

ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Feb 13, 2024

jsuarezruiz added platform/android and removed legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels Feb 13, 2024

jsuarezruiz requested review from PureWeen and removed request for jsuarezruiz February 13, 2024 14:48

jsuarezruiz reviewed Feb 22, 2024

View reviewed changes

Eilon added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Feb 29, 2024

jonathanpeppers reviewed Mar 4, 2024

View reviewed changes

src/Core/src/Handlers/TimePicker/TimePickerHandler.Android.cs Outdated Show resolved Hide resolved

src/Core/src/Handlers/TimePicker/TimePickerHandler.Android.cs Outdated Show resolved Hide resolved

jonathanpeppers reviewed Mar 5, 2024

View reviewed changes

src/Core/src/Handlers/DatePicker/DatePickerHandler.Android.cs Outdated Show resolved Hide resolved

src/Core/src/Handlers/DatePicker/DatePickerHandler.Android.cs Outdated Show resolved Hide resolved

kubaflo force-pushed the android-date-picker-focus-unfocus-events-added branch from 8841303 to 0625df0 Compare March 5, 2024 19:36

jonathanpeppers previously approved these changes Mar 5, 2024

View reviewed changes

Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024

jsuarezruiz dismissed jonathanpeppers’s stale review via 4163fea June 11, 2024 10:38

jsuarezruiz self-requested a review June 11, 2024 10:43

dotnet deleted a comment from azure-pipelines bot Jun 13, 2024

Starchm mentioned this pull request Sep 27, 2024

Improve performance of rendering DatePicker #24948

Closed

OvrBtn mentioned this pull request Oct 18, 2024

[Android] Create DatePickerDialog on demand #25363

Open

kubaflo dismissed jsuarezruiz’s stale review via 6ab422d November 15, 2024 01:41

kubaflo force-pushed the android-date-picker-focus-unfocus-events-added branch from 6874961 to 6ab422d Compare November 15, 2024 01:41

kubaflo force-pushed the android-date-picker-focus-unfocus-events-added branch from 6ab422d to 74b20c7 Compare March 2, 2025 00:00

kubaflo mentioned this pull request Mar 2, 2025

[Android] Picker - focus/unfocus events #28122

Merged

kubaflo force-pushed the android-date-picker-focus-unfocus-events-added branch from 74b20c7 to b5e571f Compare March 8, 2025 01:25

kubaflo self-assigned this Mar 8, 2025

mattleibow approved these changes May 30, 2025

View reviewed changes

kubaflo added 2 commits May 30, 2025 23:25

Added focus and unfocus events for date picker

0d5aef1

Modified test

344f3ef

github-actions bot force-pushed the android-date-picker-focus-unfocus-events-added branch from b5e571f to 344f3ef Compare May 30, 2025 23:25

bhavanesh2001 reviewed May 31, 2025

View reviewed changes

PureWeen requested changes Jun 6, 2025

View reviewed changes

PureWeen closed this Jun 20, 2025

github-actions bot locked and limited conversation to collaborators Jul 21, 2025

[Android] DatePicker Focus and Unfocus events #20547

[Android] DatePicker Focus and Unfocus events #20547

Uh oh!

Conversation

kubaflo commented Feb 13, 2024

Description of Change

Issues Fixed

Uh oh!

ghost commented Feb 13, 2024

Uh oh!

jsuarezruiz commented Feb 22, 2024

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

kubaflo commented Feb 22, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jonathanpeppers left a comment

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Mar 21, 2024

Uh oh!

azure-pipelines bot commented Mar 21, 2024

Uh oh!

mos379 commented Apr 30, 2024

Uh oh!

jsuarezruiz commented May 10, 2024

Uh oh!

azure-pipelines bot commented May 10, 2024

Uh oh!

pmigliore commented May 28, 2024

Uh oh!

jsuarezruiz commented Jun 13, 2024

Uh oh!

danbrannanavontus commented Aug 13, 2024

Uh oh!

brinawebb commented Aug 13, 2024

Uh oh!

ryanaw83 commented Aug 13, 2024

Uh oh!

PureWeen commented Sep 7, 2024

Uh oh!

azure-pipelines bot commented Sep 7, 2024

Uh oh!

mos379 commented Nov 15, 2024

Uh oh!

jsuarezruiz commented Nov 15, 2024

Uh oh!

azure-pipelines bot commented Nov 15, 2024

Uh oh!

bhavanesh2001 commented Apr 17, 2025

Uh oh!

mattleibow commented May 30, 2025

Uh oh!

mattleibow left a comment

Choose a reason for hiding this comment

Uh oh!

mattleibow commented May 30, 2025

Uh oh!

mattleibow commented May 30, 2025

Uh oh!

azure-pipelines bot commented May 30, 2025

Uh oh!

bhavanesh2001 left a comment

Choose a reason for hiding this comment

Uh oh!

PureWeen left a comment

Choose a reason for hiding this comment

Uh oh!

PureWeen commented Jun 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone