[Catalyst] Fix Selectors for Menus #20699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drasticactions
changed the title
jsuarezruiz
added
platform/macOS 🍏
jsuarezruiz
approved these changes
Feb 19, 2024
rmarinho
approved these changes
Feb 19, 2024
This was referenced Feb 20, 2024
rmarinho
pushed a commit
that referenced
this pull request
Feb 22, 2024
rmarinho
pushed a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Setting
Staticon a ObjC selector breaks it, so we accidentally broke all Menu flyout options for Mac Catalyst, including those bound with Commands and Clicks.Removing Static fixes it.
Issues Fixed
Fixes #20685