-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Maps Project API Docs #20893
Merged
Merged
Update Maps Project API Docs #20893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
area-docs
Conceptual docs, API docs, Samples
t/housekeeping ♻︎
area/Maps🗺
labels
Feb 28, 2024
jknaudt21
requested changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some docs for the boolean properties should follow the more standard wording "Gets or sets a value that indicates ...".
More info: https://github.com/dotnet/dotnet-api-docs/wiki/Summary%3A-Property
Other than that lgtm.
jknaudt21
approved these changes
Feb 28, 2024
/rebase |
jsuarezruiz
approved these changes
Feb 29, 2024
Co-authored-by: Juan Diego Herrera <juherrera@microsoft.com>
github-actions
bot
force-pushed
the
complete-maps-apidocs
branch
from
February 29, 2024 10:39
1ebbe03
to
72d74f2
Compare
Test failures unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-controls-map
Map / Maps
area-docs
Conceptual docs, API docs, Samples
fixed-in-8.0.10
fixed-in-9.0.0-preview.3.10457
t/housekeeping ♻︎
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This adds all the missing API docs for the Maps project. Additionally this enables build errors when public XML docs are not found where they should be in order to prevent future documentation from being forgotten.
Issues Fixed
Related to #3960